Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Support App Privacy Manifest #709

Open
4 tasks done
keitanxkeitan opened this issue Jan 10, 2024 · 28 comments
Open
4 tasks done

Feature Request: Support App Privacy Manifest #709

keitanxkeitan opened this issue Jan 10, 2024 · 28 comments

Comments

@keitanxkeitan
Copy link

Checklist

  • I've updated to the latest released version of the SDK
  • I've searched for existing feature requests on GitHub issues
  • I've read the Code of Conduct
  • I've given my issue the title: Feature Request: [name of my feature request]

Goals

Apple required App Privacy manifests until 2025. So Facebook SDK that contains an app privacy manifest must be signed.
I would like to know when you adopt this change.

References
https://developer.apple.com/videos/play/wwdc2023/10060/
https://developer.apple.com/news/?id=av1nevon
https://developer.apple.com/app-store/user-privacy-and-data-use/

Please check it out. Thanks!

Expected Results

Add Privacy Manifest

Code Samples & Details

No response

@gtalwadkar
Copy link

Any update on this?

@cberkeleyHutch
Copy link

Is there an ETA on this?

@BogdanBobkov
Copy link

Hi guys,
is there any updates?

@Viabo
Copy link

Viabo commented Mar 26, 2024

Guys, any update on this?

https://developer.apple.com/news/?id=3d8a9yyh - Apple released information about dates, it is required already on May 1, 2024
https://developer.apple.com/support/third-party-SDK-requirements/ - FB SDK is in the list of SDKs that are required to have privacy manifest

@shmuelvpapaya
Copy link

@facebook-github-bot - any updates on it? this is crucial for many developers now

@SergeyChereshnyuk
Copy link

Facebook SDK v17.0.0 is released. Do you have some news?

@EmmetBeachBum
Copy link

Joining this thread - Would love an update if anyone has some new info.

@psstevenchan
Copy link

any news ? last facebook unity sdk is 16.0.2 that is Aug 31, 2023

@arturkorzh
Copy link

for unity you can try change pods dependencies on v17.0.0 for iOS target

@lurenzhangdeshuai
Copy link

for unity you can try change pods dependencies on v17.0.0 for iOS target

CocoaPods could not find compatible versions for pod "FBSDKShareKit":
In Podfile:
FBSDKShareKit (= 17.0.0)

or

[!] CocoaPods could not find compatible versions for pod "FBSDKShareKit":
In Podfile:
FBSDKShareKit (~> 17.0)

@lurenzhangdeshuai
Copy link

any news ? last facebook unity sdk is 16.0.2 that is Aug 31, 2023

@supergardener
Copy link

Any updates?

1 similar comment
@CSystem
Copy link

CSystem commented Apr 12, 2024

Any updates?

@arturkorzh
Copy link

for unity you can try change pods dependencies on v17.0.0 for iOS target

CocoaPods could not find compatible versions for pod "FBSDKShareKit": In Podfile: FBSDKShareKit (= 17.0.0)

or

[!] CocoaPods could not find compatible versions for pod "FBSDKShareKit": In Podfile: FBSDKShareKit (~> 17.0)

i mean dependency.xml in plugin folder like version="~> 17.0.0"

@lurenzhangdeshuai
Copy link

for unity you can try change pods dependencies on v17.0.0 for iOS target

CocoaPods could not find compatible versions for pod "FBSDKShareKit": In Podfile: FBSDKShareKit (= 17.0.0)
or
[!] CocoaPods could not find compatible versions for pod "FBSDKShareKit": In Podfile: FBSDKShareKit (~> 17.0)

i mean dependency.xml in plugin folder like version="~> 17.0.0"

[!] CocoaPods could not find compatible versions for pod "FBSDKShareKit":
In Podfile:
FBSDKShareKit (~> 17.0.0)

None of your spec sources contain a spec satisfying the dependency: FBSDKShareKit (~> 17.0.0). T T

@D117
Copy link

D117 commented Apr 12, 2024

Any updates on this?
The clock is ticking and we are not that far away from the deadline set on May 1, 2024.
We just have 2 weeks before the time is up, and then any submission on the App Store of our Unity applications will require us to have a compliant Facebook Unity SDK.
Facebook, could you give us an ETA on this, please?

@daltonbr
Copy link

+1

@jnbt
Copy link

jnbt commented Apr 12, 2024

Is there an ETA on this? Otherwise we all need to remove the Facebook SDK for Unity from the games in order to be able to ship updated in 2 weeks.

@esigma5
Copy link

esigma5 commented Apr 12, 2024

We are a gaming company which depends on it.
An ETA or at least a message like "we don't do it" would be appreciated, so we can plan our own upgrades accorddinly.

@sddd1234567
Copy link

sddd1234567 commented Apr 15, 2024

Has anyone tried directly changing the ios-sdk version of CocoaPods to 17.0.0?
I've attempted to use facebook-unity-sdk 16.0.2 and change the ios-sdk version from 16.0.2 to 17.0.0 directly in the dependency.xml, and successfully built the app.
However, I'm unsure if running it this way might lead to unexpected errors. Has anyone else tried this?

@lurenzhangdeshuai
Copy link

Has anyone tried directly changing the ios-sdk version of CocoaPods to 17.0.0? I've attempted to use facebook-unity-sdk 16.0.2 and change the ios-sdk version from 16.0.2 to 17.0.0 directly in the dependency.xml, and successfully built the app. However, I'm unsure if running it this way might lead to unexpected errors. Has anyone else tried this?

I've tried but failed

@jnbt
Copy link

jnbt commented Apr 18, 2024

To all who are looking for it: Yesterday Facebook released an update of the Unity SDK, which claims to address the "privacy manifest".

https://developers.facebook.com/docs/unity/change-log

(Note: I have not yet tested it myself)

@Moayad-Rahhal
Copy link

Hi, I'm using Unity 2021.3.37 LTS and Facebook 17.0.0
Once I build the iOS I get this file
Screenshot 2024-04-21 at 5 05 54 PM

After importing the new Facebook SDK I also got the same, Do I miss something, or is importing the SDK fixing this issue?
Screenshot 2024-04-21 at 5 05 54 PM

@AvenNight
Copy link

AvenNight commented Apr 26, 2024

I updated Unity to version 2022.3.22, firebase, fbm to 10.22.0 and facebook to version 17.0.0
I see that UnityFramework and all SDKs except Facebook have registered private manifests.

I also see the same errors when uploading to the app store.

I have been working with Facebook SDK for a long time and quite often they release crooked updates when I had to roll back versions or finish something manually, so there are suspicions that they again did not foresee something.

If I'm wrong, please tell me someone that everything is fine with you or tell me what I can do about my side?

Thank you
image (15)
image (16)

UP:
By the way, if someone is unable to build with a similar error:
ld: Assertion failed: (false && "compact unwind compressed function offset doesn't fit in 24 bits"), function operator(), file Layout.cpp, line 5758.
add this to the postbuild (It helped me to):

string projectPath = PBXProject.GetPBXProjectPath(path);
PBXProject project = new PBXProject();
project.ReadFromFile(projectPath);

// Unity Framework: Add `-ld_classic` to "Other Linker Flags".
var targetUnityFramework = project.GetUnityFrameworkTargetGuid();
project.AddBuildProperty(targetUnityFramework, "OTHER_LDFLAGS", "-ld_classic");

@bilalakil
Copy link

Hi all,

Pointing out that the Privacy Manifests appear to have been added, but not in a way that would result in them being merged into the UnityFramework's privacy manifest (which would explain why it's not being found in the screenshots posted by others above).

My assumption (unconfirmed - haven't researched / submitted to App Store yet) is that the privacy manifests of ALL frameworks (not just the UnityFramework) are considered for apps, so things should be good now.

However, @AvenNight 's post just above may suggest otherwise 🤔

Before/after comparison:

v16.0 FBSDKCoreKit.Framework content:
image

v17.0.1 FBSDKCodeKit.Framework content:
image

@AvenNight
Copy link

@bilalakil hmm, it’s very strange that your Pods version is FBSDKCodeKit 17.0.1, while mine is 17.0.0 without PrivacyInfo
FBSDKCodeKit.Framework content:
image

I took the Unity SDK from here:
https://developers.facebook.com/docs/unity/change-log#facebook-sdk-for-unity-changelog

Do you have any ideas what could be wrong?

@AvenNight
Copy link

AvenNight commented May 7, 2024

i manually change version 17.0.1 (I also updated the Pods etc.)
image

in the end it helped and PrivacyInfo.xcprivacy appeared:
image

Now let's try to upload this to the app store!
I'll keep posted (:

@bilalakil
Copy link

Our app was approved and released with 17.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests