-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why doesn't Init(...) follow the same "structure" as all other IFacebook methods? #9
Comments
Nice! Are you using the SDK from Microsoft at Upgrading this is something we never got around to upgrading the sdk from v6 to v7. It could be done pretty easily on the backend but we would want the public method to remain the same. |
Yes I'm using the SDK you mentioned. :) I've successfully implemented everything and it's working and is following the same 'design' as the rest of the SDK, but I'm unsatisfied by the method Sorry if there's something I'm missing here! |
Generally in our SDKs we try to avoid changes that a breaking unless completely necessary or we move to a new sdk such as v8. I agree that it would be nice to have some of the information such as the access token. What I think would be nice if we
|
Looking forward to the Init(...) changes! I've now made a pull request containing the support for UWP. |
Thanks for putting the effort in bringing Windows to the SDK, this is something I needed and wasn't sure how to do myself :) |
The master branch on my fork should be working, but only for UWP apps (Windows 10 (and Mobile)) at the moment. It's worth noting though that the |
Windows phone is no longer supported in unity |
I just checked the last few unity release notes. It seems that they stopped supporting WP8, but WP8.1 is still supported (as well as Win10 Mobile). |
Sorry for the vague description in the title.
If you look at all the methods available in the IFacebook.cs interface, almost all have a callback which looks like
FacebookDelegate<IResult>
whereIResult
may differ depending on the call. But theInit(...)
method doesn't follow this. It has it's ownInitDelegate
delegate which feels kinda out of place and doesn't return any information. And that would be fine...But the methodOnInitComplete(string message)
will in turn callOnLoginComplete(message)
for some reason (and what shouldmessage
be in this case, since I don't have any data to go on?).Why does all of this matter to me? I'm trying to wrap the new UWP Facebook SDK (from Microsoft) into your SDK. And I'm trying to make sure everything follows the same event-stucture as Android and iOS and the only thing missing now is the
Init
-method which is...weird.Summary:
I want to be able to do the following:
string callback_id = CallbackManager.AddFacebookDelegate(myInitCallback).toString();
var dontKnowWhatItShouldContainOtherThenCallbackId = new Dictionary<string,object>();
dontKnowWhatItShouldContainOtherThenCallbackId.Add("callback_id", callback_id);
OnInitComplete(MiniJSON.Json.Serialize(dontKnowWhatItShouldContainOtherThenCallbackId)); //This should also invoke myInitCallback as it does with all other methods.
The text was updated successfully, but these errors were encountered: