This repository has been archived by the owner on Mar 3, 2020. It is now read-only.
Use the correct CSS selector to find out if names are required #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The selector `#register_names` doesn't seem to be in the DOM. This change replaces that check with one that checks for the value of the hidden input named `action`. If that value is `register_names` we make sure to collect the names and add them to the AJAX response to the server. Fixes facebookarchive#86
|
Thanks for the PR! I verified the fix and it makes the registration to collect the names and emails. |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The selector
#register_namesdoesn't seem to be in the DOM.This change replaces that check with one that checks for the value of the hidden input named
action. If that value isregister_nameswe make sure to collect the names and add them to the AJAX response to the server.Fixes #86