Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fbjs-scripts] gulp/check-dependencies should handle outdated non-deps safely #158

Closed
zpao opened this issue Jul 11, 2016 · 0 comments
Closed

Comments

@zpao
Copy link
Member

zpao commented Jul 11, 2016

This is only an issue after removing dependencies from package.json but we should handle it better. Specifically if you have an outdated package installed npm outdated will report it even if it's no longer a dep. But then out lookup to see if it's ok fails because it expects it.

This is easily handled. We can either skip that package or we can have gulp throw an error saying that you should run npm prune.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant