Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Cannot read property 'startsWith' of undefined" in gulp/check-dependencies.js #174

Closed
sophiebits opened this issue Aug 22, 2016 · 5 comments

Comments

@sophiebits
Copy link
Contributor

This happens sometimes:

[11:48:06] Using gulpfile ~/code/draft-js/gulpfile.js
[11:48:06] Starting 'default'...
[11:48:06] Starting 'check-dependencies'...
/Users/balpert/code/draft-js/node_modules/fbjs-scripts/gulp/check-dependencies.js:48
        if (!requested.startsWith('file:') && !semver.satisfies(current, requested)) {
                      ^

TypeError: Cannot read property 'startsWith' of undefined

outdatedData and pkgData: https://gist.github.com/spicyj/a50292f0d7fc760332177ae281fca4e7

@zpao
Copy link
Member

zpao commented Aug 23, 2016

Most sure this is what I suspected when we were chatting. You have jest and jest-cli showing up in outdated but only jest in package.json. No entry in requested means it throws :(

Easy fix (ignore anything not in package.json, maybe warn & encourage cleanup?). Easy work around too which I'm sure you've figured out. Clobber node_modules or run npm prune

@zpao
Copy link
Member

zpao commented Aug 23, 2016

Oops, turns out I knew about this and filed #158.

@zpao zpao closed this as completed Aug 23, 2016
@maratgaip
Copy link

"startsWith" doesn't work with IE and i have problem when i'm working with draftJs...
do you have polyfill already for that one or should i pull request and add polyfill?

@sophiebits
Copy link
Contributor Author

@maratgaip This is a totally unrelated issue.

@maratgaip
Copy link

@spicyj ups, i thought i created a new issue... sorry thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants