move sai fake to sai 1.12.0 #147
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: As titled, move sai fake sai to 1.12.0. BCM and TAJO P4 WB SDK already moved to 1.12.0 and its good to move fake also to the same version. This diff addresses: - Moving SAI version for fake from sai version 1.7 to 1.12 - Update sandcastle job to build the fake sai 1.12 - saiobject.h includes experimental header files as part of SAI 1.12 and hence the include path has to contain both sai/include and sai/experimental. Currently, vendors leverage the experimental header files differently (by placing include and experimental in the same include dir) than SAI spec but eventually we will have vendors also converge to the same model. Changing it now will break BCM builds. - Ignore including Saiversion.h in OSS since 1.12 contains saiversion.h already and defines SAI_VERSION and SAI_API_VERSION macros. NOTE that this should not alter BCM OSS builds. Reviewed By: shri-khare Differential Revision: D47779384 fbshipit-source-id: 18b31d337ed81efaea4a0b1bcc9c30c18aa11edf
|
This pull request was exported from Phabricator. Differential Revision: D47779384 |
facebook-github-bot
pushed a commit
to facebook/sapling
that referenced
this pull request
Jul 28, 2023
Summary: X-link: facebook/fboss#147 As titled, move sai fake sai to 1.12.0. BCM and TAJO P4 WB SDK already moved to 1.12.0 and its good to move fake also to the same version. This diff addresses: - Moving SAI version for fake from sai version 1.7 to 1.12 - Update sandcastle job to build the fake sai 1.12 - saiobject.h includes experimental header files as part of SAI 1.12 and hence the include path has to contain both sai/include and sai/experimental. Currently, vendors leverage the experimental header files differently (by placing include and experimental in the same include dir) than SAI spec but eventually we will have vendors also converge to the same model. Changing it now will break BCM builds. - Ignore including Saiversion.h in OSS since 1.12 contains saiversion.h already and defines SAI_VERSION and SAI_API_VERSION macros. NOTE that this should not alter BCM OSS builds. Reviewed By: shri-khare Differential Revision: D47779384 fbshipit-source-id: ba10a35dd95306c908c5cd3f76a1485461b011d7
facebook-github-bot
pushed a commit
to facebook/proxygen
that referenced
this pull request
Jul 28, 2023
Summary: X-link: facebook/fboss#147 As titled, move sai fake sai to 1.12.0. BCM and TAJO P4 WB SDK already moved to 1.12.0 and its good to move fake also to the same version. This diff addresses: - Moving SAI version for fake from sai version 1.7 to 1.12 - Update sandcastle job to build the fake sai 1.12 - saiobject.h includes experimental header files as part of SAI 1.12 and hence the include path has to contain both sai/include and sai/experimental. Currently, vendors leverage the experimental header files differently (by placing include and experimental in the same include dir) than SAI spec but eventually we will have vendors also converge to the same model. Changing it now will break BCM builds. - Ignore including Saiversion.h in OSS since 1.12 contains saiversion.h already and defines SAI_VERSION and SAI_API_VERSION macros. NOTE that this should not alter BCM OSS builds. Reviewed By: shri-khare Differential Revision: D47779384 fbshipit-source-id: ba10a35dd95306c908c5cd3f76a1485461b011d7
facebook-github-bot
pushed a commit
to facebook/mvfst
that referenced
this pull request
Jul 28, 2023
Summary: X-link: facebook/fboss#147 As titled, move sai fake sai to 1.12.0. BCM and TAJO P4 WB SDK already moved to 1.12.0 and its good to move fake also to the same version. This diff addresses: - Moving SAI version for fake from sai version 1.7 to 1.12 - Update sandcastle job to build the fake sai 1.12 - saiobject.h includes experimental header files as part of SAI 1.12 and hence the include path has to contain both sai/include and sai/experimental. Currently, vendors leverage the experimental header files differently (by placing include and experimental in the same include dir) than SAI spec but eventually we will have vendors also converge to the same model. Changing it now will break BCM builds. - Ignore including Saiversion.h in OSS since 1.12 contains saiversion.h already and defines SAI_VERSION and SAI_API_VERSION macros. NOTE that this should not alter BCM OSS builds. Reviewed By: shri-khare Differential Revision: D47779384 fbshipit-source-id: ba10a35dd95306c908c5cd3f76a1485461b011d7
facebook-github-bot
pushed a commit
to facebookincubator/velox
that referenced
this pull request
Jul 28, 2023
Summary: X-link: facebook/fboss#147 As titled, move sai fake sai to 1.12.0. BCM and TAJO P4 WB SDK already moved to 1.12.0 and its good to move fake also to the same version. This diff addresses: - Moving SAI version for fake from sai version 1.7 to 1.12 - Update sandcastle job to build the fake sai 1.12 - saiobject.h includes experimental header files as part of SAI 1.12 and hence the include path has to contain both sai/include and sai/experimental. Currently, vendors leverage the experimental header files differently (by placing include and experimental in the same include dir) than SAI spec but eventually we will have vendors also converge to the same model. Changing it now will break BCM builds. - Ignore including Saiversion.h in OSS since 1.12 contains saiversion.h already and defines SAI_VERSION and SAI_API_VERSION macros. NOTE that this should not alter BCM OSS builds. Reviewed By: shri-khare Differential Revision: D47779384 fbshipit-source-id: ba10a35dd95306c908c5cd3f76a1485461b011d7
|
This pull request has been merged in dac2334. |
facebook-github-bot
pushed a commit
to facebook/fbthrift
that referenced
this pull request
Jul 28, 2023
Summary: X-link: facebook/fboss#147 As titled, move sai fake sai to 1.12.0. BCM and TAJO P4 WB SDK already moved to 1.12.0 and its good to move fake also to the same version. This diff addresses: - Moving SAI version for fake from sai version 1.7 to 1.12 - Update sandcastle job to build the fake sai 1.12 - saiobject.h includes experimental header files as part of SAI 1.12 and hence the include path has to contain both sai/include and sai/experimental. Currently, vendors leverage the experimental header files differently (by placing include and experimental in the same include dir) than SAI spec but eventually we will have vendors also converge to the same model. Changing it now will break BCM builds. - Ignore including Saiversion.h in OSS since 1.12 contains saiversion.h already and defines SAI_VERSION and SAI_API_VERSION macros. NOTE that this should not alter BCM OSS builds. Reviewed By: shri-khare Differential Revision: D47779384 fbshipit-source-id: ba10a35dd95306c908c5cd3f76a1485461b011d7
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Aug 1, 2023
Summary: X-link: facebook/fboss#147 As titled, move sai fake sai to 1.12.0. BCM and TAJO P4 WB SDK already moved to 1.12.0 and its good to move fake also to the same version. This diff addresses: - Moving SAI version for fake from sai version 1.7 to 1.12 - Update sandcastle job to build the fake sai 1.12 - saiobject.h includes experimental header files as part of SAI 1.12 and hence the include path has to contain both sai/include and sai/experimental. Currently, vendors leverage the experimental header files differently (by placing include and experimental in the same include dir) than SAI spec but eventually we will have vendors also converge to the same model. Changing it now will break BCM builds. - Ignore including Saiversion.h in OSS since 1.12 contains saiversion.h already and defines SAI_VERSION and SAI_API_VERSION macros. NOTE that this should not alter BCM OSS builds. Reviewed By: shri-khare Differential Revision: D47779384 fbshipit-source-id: ba10a35dd95306c908c5cd3f76a1485461b011d7
facebook-github-bot
pushed a commit
to facebook/folly
that referenced
this pull request
Aug 1, 2023
Summary: X-link: facebook/fboss#147 As titled, move sai fake sai to 1.12.0. BCM and TAJO P4 WB SDK already moved to 1.12.0 and its good to move fake also to the same version. This diff addresses: - Moving SAI version for fake from sai version 1.7 to 1.12 - Update sandcastle job to build the fake sai 1.12 - saiobject.h includes experimental header files as part of SAI 1.12 and hence the include path has to contain both sai/include and sai/experimental. Currently, vendors leverage the experimental header files differently (by placing include and experimental in the same include dir) than SAI spec but eventually we will have vendors also converge to the same model. Changing it now will break BCM builds. - Ignore including Saiversion.h in OSS since 1.12 contains saiversion.h already and defines SAI_VERSION and SAI_API_VERSION macros. NOTE that this should not alter BCM OSS builds. Reviewed By: shri-khare Differential Revision: D47779384 fbshipit-source-id: ba10a35dd95306c908c5cd3f76a1485461b011d7
facebook-github-bot
pushed a commit
to facebookexperimental/rust-shed
that referenced
this pull request
Aug 3, 2023
Summary: X-link: facebook/fboss#147 As titled, move sai fake sai to 1.12.0. BCM and TAJO P4 WB SDK already moved to 1.12.0 and its good to move fake also to the same version. This diff addresses: - Moving SAI version for fake from sai version 1.7 to 1.12 - Update sandcastle job to build the fake sai 1.12 - saiobject.h includes experimental header files as part of SAI 1.12 and hence the include path has to contain both sai/include and sai/experimental. Currently, vendors leverage the experimental header files differently (by placing include and experimental in the same include dir) than SAI spec but eventually we will have vendors also converge to the same model. Changing it now will break BCM builds. - Ignore including Saiversion.h in OSS since 1.12 contains saiversion.h already and defines SAI_VERSION and SAI_API_VERSION macros. NOTE that this should not alter BCM OSS builds. Reviewed By: shri-khare Differential Revision: D47779384 fbshipit-source-id: ba10a35dd95306c908c5cd3f76a1485461b011d7
facebook-github-bot
pushed a commit
to facebook/fb303
that referenced
this pull request
Aug 3, 2023
Summary: X-link: facebook/fboss#147 As titled, move sai fake sai to 1.12.0. BCM and TAJO P4 WB SDK already moved to 1.12.0 and its good to move fake also to the same version. This diff addresses: - Moving SAI version for fake from sai version 1.7 to 1.12 - Update sandcastle job to build the fake sai 1.12 - saiobject.h includes experimental header files as part of SAI 1.12 and hence the include path has to contain both sai/include and sai/experimental. Currently, vendors leverage the experimental header files differently (by placing include and experimental in the same include dir) than SAI spec but eventually we will have vendors also converge to the same model. Changing it now will break BCM builds. - Ignore including Saiversion.h in OSS since 1.12 contains saiversion.h already and defines SAI_VERSION and SAI_API_VERSION macros. NOTE that this should not alter BCM OSS builds. Reviewed By: shri-khare Differential Revision: D47779384 fbshipit-source-id: ba10a35dd95306c908c5cd3f76a1485461b011d7
facebook-github-bot
pushed a commit
to facebook/wangle
that referenced
this pull request
Aug 3, 2023
Summary: X-link: facebook/fboss#147 As titled, move sai fake sai to 1.12.0. BCM and TAJO P4 WB SDK already moved to 1.12.0 and its good to move fake also to the same version. This diff addresses: - Moving SAI version for fake from sai version 1.7 to 1.12 - Update sandcastle job to build the fake sai 1.12 - saiobject.h includes experimental header files as part of SAI 1.12 and hence the include path has to contain both sai/include and sai/experimental. Currently, vendors leverage the experimental header files differently (by placing include and experimental in the same include dir) than SAI spec but eventually we will have vendors also converge to the same model. Changing it now will break BCM builds. - Ignore including Saiversion.h in OSS since 1.12 contains saiversion.h already and defines SAI_VERSION and SAI_API_VERSION macros. NOTE that this should not alter BCM OSS builds. Reviewed By: shri-khare Differential Revision: D47779384 fbshipit-source-id: ba10a35dd95306c908c5cd3f76a1485461b011d7
facebook-github-bot
pushed a commit
to facebook/watchman
that referenced
this pull request
Aug 4, 2023
Summary: X-link: facebook/fboss#147 As titled, move sai fake sai to 1.12.0. BCM and TAJO P4 WB SDK already moved to 1.12.0 and its good to move fake also to the same version. This diff addresses: - Moving SAI version for fake from sai version 1.7 to 1.12 - Update sandcastle job to build the fake sai 1.12 - saiobject.h includes experimental header files as part of SAI 1.12 and hence the include path has to contain both sai/include and sai/experimental. Currently, vendors leverage the experimental header files differently (by placing include and experimental in the same include dir) than SAI spec but eventually we will have vendors also converge to the same model. Changing it now will break BCM builds. - Ignore including Saiversion.h in OSS since 1.12 contains saiversion.h already and defines SAI_VERSION and SAI_API_VERSION macros. NOTE that this should not alter BCM OSS builds. Reviewed By: shri-khare Differential Revision: D47779384 fbshipit-source-id: ba10a35dd95306c908c5cd3f76a1485461b011d7
facebook-github-bot
pushed a commit
to facebookexperimental/edencommon
that referenced
this pull request
Aug 4, 2023
Summary: X-link: facebook/fboss#147 As titled, move sai fake sai to 1.12.0. BCM and TAJO P4 WB SDK already moved to 1.12.0 and its good to move fake also to the same version. This diff addresses: - Moving SAI version for fake from sai version 1.7 to 1.12 - Update sandcastle job to build the fake sai 1.12 - saiobject.h includes experimental header files as part of SAI 1.12 and hence the include path has to contain both sai/include and sai/experimental. Currently, vendors leverage the experimental header files differently (by placing include and experimental in the same include dir) than SAI spec but eventually we will have vendors also converge to the same model. Changing it now will break BCM builds. - Ignore including Saiversion.h in OSS since 1.12 contains saiversion.h already and defines SAI_VERSION and SAI_API_VERSION macros. NOTE that this should not alter BCM OSS builds. Reviewed By: shri-khare Differential Revision: D47779384 fbshipit-source-id: ba10a35dd95306c908c5cd3f76a1485461b011d7
facebook-github-bot
pushed a commit
to facebookincubator/fizz
that referenced
this pull request
Aug 4, 2023
Summary: X-link: facebook/fboss#147 As titled, move sai fake sai to 1.12.0. BCM and TAJO P4 WB SDK already moved to 1.12.0 and its good to move fake also to the same version. This diff addresses: - Moving SAI version for fake from sai version 1.7 to 1.12 - Update sandcastle job to build the fake sai 1.12 - saiobject.h includes experimental header files as part of SAI 1.12 and hence the include path has to contain both sai/include and sai/experimental. Currently, vendors leverage the experimental header files differently (by placing include and experimental in the same include dir) than SAI spec but eventually we will have vendors also converge to the same model. Changing it now will break BCM builds. - Ignore including Saiversion.h in OSS since 1.12 contains saiversion.h already and defines SAI_VERSION and SAI_API_VERSION macros. NOTE that this should not alter BCM OSS builds. Reviewed By: shri-khare Differential Revision: D47779384 fbshipit-source-id: ba10a35dd95306c908c5cd3f76a1485461b011d7
facebook-github-bot
pushed a commit
to facebookincubator/katran
that referenced
this pull request
Aug 4, 2023
Summary: X-link: facebook/fboss#147 As titled, move sai fake sai to 1.12.0. BCM and TAJO P4 WB SDK already moved to 1.12.0 and its good to move fake also to the same version. This diff addresses: - Moving SAI version for fake from sai version 1.7 to 1.12 - Update sandcastle job to build the fake sai 1.12 - saiobject.h includes experimental header files as part of SAI 1.12 and hence the include path has to contain both sai/include and sai/experimental. Currently, vendors leverage the experimental header files differently (by placing include and experimental in the same include dir) than SAI spec but eventually we will have vendors also converge to the same model. Changing it now will break BCM builds. - Ignore including Saiversion.h in OSS since 1.12 contains saiversion.h already and defines SAI_VERSION and SAI_API_VERSION macros. NOTE that this should not alter BCM OSS builds. Reviewed By: shri-khare Differential Revision: D47779384 fbshipit-source-id: ba10a35dd95306c908c5cd3f76a1485461b011d7
facebook-github-bot
pushed a commit
to facebookincubator/hsthrift
that referenced
this pull request
Oct 11, 2023
Summary: X-link: facebook/fboss#147 As titled, move sai fake sai to 1.12.0. BCM and TAJO P4 WB SDK already moved to 1.12.0 and its good to move fake also to the same version. This diff addresses: - Moving SAI version for fake from sai version 1.7 to 1.12 - Update sandcastle job to build the fake sai 1.12 - saiobject.h includes experimental header files as part of SAI 1.12 and hence the include path has to contain both sai/include and sai/experimental. Currently, vendors leverage the experimental header files differently (by placing include and experimental in the same include dir) than SAI spec but eventually we will have vendors also converge to the same model. Changing it now will break BCM builds. - Ignore including Saiversion.h in OSS since 1.12 contains saiversion.h already and defines SAI_VERSION and SAI_API_VERSION macros. NOTE that this should not alter BCM OSS builds. Reviewed By: shri-khare Differential Revision: D47779384 fbshipit-source-id: ba10a35dd95306c908c5cd3f76a1485461b011d7
facebook-github-bot
pushed a commit
to facebook/openr
that referenced
this pull request
Jan 9, 2024
Summary: X-link: facebook/fboss#147 As titled, move sai fake sai to 1.12.0. BCM and TAJO P4 WB SDK already moved to 1.12.0 and its good to move fake also to the same version. This diff addresses: - Moving SAI version for fake from sai version 1.7 to 1.12 - Update sandcastle job to build the fake sai 1.12 - saiobject.h includes experimental header files as part of SAI 1.12 and hence the include path has to contain both sai/include and sai/experimental. Currently, vendors leverage the experimental header files differently (by placing include and experimental in the same include dir) than SAI spec but eventually we will have vendors also converge to the same model. Changing it now will break BCM builds. - Ignore including Saiversion.h in OSS since 1.12 contains saiversion.h already and defines SAI_VERSION and SAI_API_VERSION macros. NOTE that this should not alter BCM OSS builds. Reviewed By: shri-khare Differential Revision: D47779384 fbshipit-source-id: ba10a35dd95306c908c5cd3f76a1485461b011d7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
As titled, move sai fake sai to 1.12.0. BCM and TAJO P4 WB SDK already moved to 1.12.0 and its good to move fake also to the same version.
This diff addresses:
NOTE that this should not alter BCM OSS builds.
Reviewed By: shri-khare
Differential Revision: D47779384