Skip to content
This repository has been archived by the owner on Jun 7, 2023. It is now read-only.

Commit

Permalink
Cleanup .travis.sh and fix TravisCI (#90)
Browse files Browse the repository at this point in the history
Summary:
* /bin/sh is not guaranteed to include `$()`, /bin/bash is
* Remove `composer.lock` to align with other hhvm projects
* `composer upgrade` can't install packages if `composer.lock` is missing, use `composer install` instead
* `vendor/**/tests` cause problems when composer clones dependencies instead of using release tarballs.
Pull Request resolved: #90

Reviewed By: wittgenst

Differential Revision: D20630520

Pulled By: yns88

fbshipit-source-id: 52c4422c2127ebf10d98152dea48cda62517544f
  • Loading branch information
bigfootjon authored and facebook-github-bot committed Mar 26, 2020
1 parent b594c11 commit d64bc53
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 330 deletions.
1 change: 1 addition & 0 deletions .gitignore
@@ -1 +1,2 @@
vendor/
composer.lock
1 change: 1 addition & 0 deletions .hhconfig
Expand Up @@ -2,3 +2,4 @@ assume_php = false
safe_array = true
safe_vector_array = true
version = 3.0.0
ignored_paths = [ "^vendor/.*/tests?/" ]
4 changes: 2 additions & 2 deletions .travis.sh
@@ -1,4 +1,4 @@
#!/bin/sh
#!/bin/bash
set -ex

add-apt-repository ppa:git-core/ppa
Expand All @@ -23,7 +23,7 @@ hhvm --version
curl https://getcomposer.org/installer | php -- /dev/stdin --install-dir=/usr/local/bin --filename=composer

cd /var/source
php /usr/local/bin/composer update
php /usr/local/bin/composer install

hh_server --check $(pwd)
vendor/bin/hacktest tests/
328 changes: 0 additions & 328 deletions composer.lock

This file was deleted.

0 comments on commit d64bc53

Please sign in to comment.