Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Banzai? #59

Closed
Daniel15 opened this issue Apr 27, 2019 · 2 comments
Closed

Remove Banzai? #59

Daniel15 opened this issue Apr 27, 2019 · 2 comments
Assignees
@jrwats
Labels
enhancement New feature or request

Comments

@Daniel15
Copy link
Member

Daniel15 commented Apr 27, 2019 •
edited

https://github.com/facebookincubator/fbt/blob/7f90309e56b6ba2126ca6b097756c5fbd8d4666e/runtime/shared/fbt.js#L455

This is a Facebook-ism that we probably don't want to keep in the open source release. Perhaps it should have a hook to set a logger (eg. fbt.setLogger(....)) rather than having a hard dependency on Banzai (which is mocked out in this open source release).
@jrwats jrwats self-assigned this Jun 6, 2019
@jrwats jrwats added the enhancement New feature or request label Jun 6, 2019
@jrwats
Copy link
Contributor

jrwats commented Jun 6, 2019

We have a TON of (production) mocks right now that could probably be dealt with a bit better. So yeah - in the very least we can tackle this.

@jrwats
Copy link
Contributor

jrwats commented Jan 28, 2020

Fixed in GitHub with jrwats@630dea5 and is published to fbt 0.11.0

@jrwats jrwats closed this as completed Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrwats jrwats

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Daniel15 @jrwats