Skip to content

Commit

Permalink
thrift/lib/cpp2/async/AsyncClient.h: mark overriding functions with "…
Browse files Browse the repository at this point in the history
…override"

Summary:
This avoids the following errors:

  thrift/lib/cpp2/async/AsyncClient.h:55:3: error: '~InteractionHandle' overrides a destructor but is not marked 'override' [-Werror,-Wsuggest-destructor-override]

Reviewed By: r-barnes

Differential Revision: D33397490

fbshipit-source-id: 3df586869f0ef869bab186db166225c27aa2d443
  • Loading branch information
meyering authored and facebook-github-bot committed Jan 4, 2022
1 parent 3a51677 commit 38d9995
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion thrift/lib/cpp2/async/AsyncClient.h
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ class InteractionHandle : public GeneratedAsyncClient {
InteractionHandle(
std::shared_ptr<RequestChannel> channel, folly::StringPiece methodName);
InteractionHandle(std::shared_ptr<RequestChannel> channel, InteractionId id);
~InteractionHandle();
~InteractionHandle() override;
InteractionHandle(InteractionHandle&&) noexcept = default;
InteractionHandle& operator=(InteractionHandle&&);

Expand Down

0 comments on commit 38d9995

Please sign in to comment.