[regression in 2020.11.02.00] can't create dynamic relocation R_X86_64_64 against local symbol in readonly segment; recompile object files with -fPIC

[yurivict]

d: error: can't create dynamic relocation R_X86_64_64 against local symbol in readonly segment; recompile object files with -fPIC or pass '-Wl,-z,notext' to allow text relocations in the output
>>> defined in thrift/compiler/generate/CMakeFiles/compiler_generate_templates.dir/templates.cc.o
>>> referenced by templates.cc
>>>               thrift/compiler/generate/CMakeFiles/compiler_generate_templates.dir/templates.cc.o:(apache::thrift::compiler::templates_name_datas)

FreeBSD 12.2

[Boarders]

I am running into this issue trying to build fbthrift, any ideas on what to do to solve it?

[yurivict]

The error message itself says what to do.

[vitaut]

Can be done by setting the CMAKE_POSITION_INDEPENDENT_CODE CMake variable. Closing as this is more of a configuration than Thrift issue.

[yurivict]

No, this is a bug in thrift because it fails without special setting by the user.
Thrift requires PIC to build and fails to set the PIC flag.

[vitaut]

How do you build thrift? Could you provide repro command(s)?

[yurivict]

We build with cmake <args> . && make, but we use -DBUILD_SHARED_LIBS=YES in args.

When -DBUILD_SHARED_LIBS=YES is added the build should add -fPIC to build successfully.

[vitaut]

If you enable shared libraries then you should also enable PIC, the normal build configuration doesn't require any of that. That said, a PR to enable PIC if BUILD_SHARED_LIBS is set would be welcome.

[yurivict]

@vitaut

If you enable shared libraries then you should also enable PIC [...]

FYI: This isn't how cmake projects normally work. Setting BUILD_SHARED_LIBS=ON should automatically set -fPIC through cmake. This happens for virtually all projects. There's either a bug in the fbthrift project, or in cmake that is somehow triggered by fbthrift.

[vitaut]

Ah, you are right. We should enable POSITION_INDEPENDENT_CODE for some intermediate static libraries that get linked into shared libraries.

[vitaut]

This particular error should be fixed in 8a08254.