Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing dependency on RocketUpgrade headers to thriftcpp2 target #422

Closed
wants to merge 1 commit into from
Closed

Add missing dependency on RocketUpgrade headers to thriftcpp2 target #422

wants to merge 1 commit into from

Commits on Apr 10, 2021

  1. Add missing dependency on RocketUpgrade headers to thriftcpp2 target 

    One source file in this target, async/HeaderClientChannel.cpp,
depends on the generated header RocketUpgradeAsyncClient.h, so it
needs to depend on the target that generates this header.

This causes a build error with samurai due to an incorrect build
order, and can be reproduced with ninja as well by building
thrift/lib/cpp2/CMakeFiles/thriftcpp2.dir/async/HeaderClientChannel.cpp.o
directly with an empty .ninja_deps.
    @michaelforney
    michaelforney committed Apr 10, 2021
    Configuration menu
    Copy the full SHA
    70a25a6 View commit details
    Browse the repository at this point in the history