Skip to content

Commit

Permalink
Report connecting apps from the TLS socket
Browse files Browse the repository at this point in the history
Summary:
This was missing. Only apps going through the certificate exchange process were marked as 'apps trying to connect'.

This changes fixes it.

Notes:

In my tests it is not always visible as the app can establish the connection very quickly. So you may be wondering what the point is:
- Consistency across our connection process.
- It will become useful of there's a failure coming from an app that already has the client certificate.

Reviewed By: Katalune

Differential Revision: D51984388

fbshipit-source-id: 44796ed5666f4570adbfcf455063c5a56936778f
  • Loading branch information
lblasa authored and facebook-github-bot committed Dec 9, 2023
1 parent 3b142e9 commit 583c318
Showing 1 changed file with 7 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,13 @@ export class ServerController
),
);
}

const client: UninitializedClient = {
os: clientQuery.os,
deviceName: clientQuery.device,
appName: appNameWithUpdateHint(clientQuery),
};
this.emit('start-client-setup', client);
}

/**
Expand Down

0 comments on commit 583c318

Please sign in to comment.