Improve error messaging for plugin downloads

Summary:
This will only show and raise an error if no further download URLs are available. Otherwise,
cases where another download URL is still available will look as if the download failed fatally.

Reviewed By: antonk52

Differential Revision: D54984433

fbshipit-source-id: 15b02de6a573ff7dd1d53486f68efe9828a30a8f

desktop/flipper-server/src/plugins/PluginManager.tsx

@@ -130,7 +130,7 @@ export class PluginManager {
       tmpDir,
       `${getPluginDirNameFromPackageName(name)}-${version}.tgz`,
     );
-    let finalError = null;
+    let finalError: Error | null = null;
     for (const downloadUrl of downloadUrls) {
       try {
         const cancelationSource = axios.CancelToken.source();
@@ -184,17 +184,17 @@ export class PluginManager {
           return await installPluginFromFileOrBuffer(tmpFile);
         }
       } catch (error) {
-        console.warn(
-          `Failed to download plugin "${title}" v${version} from "${downloadUrl}" to "${installationDir}".`,
-          error,
-        );
         finalError = error;
         continue;
       } finally {
         await fs.remove(tmpDir);
       }
     }
 
+    console.info(
+      `Failed to download plugin "${title}" v${version} from "${downloadUrls}" to "${installationDir}".`,
+      finalError,
+    );
     throw finalError;
   }