Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What about React Native? #21

Closed
ahmedlhanafy opened this issue Jun 11, 2018 · 17 comments
Closed

What about React Native? #21

ahmedlhanafy opened this issue Jun 11, 2018 · 17 comments
Labels
enhancement New feature or request JS

Comments

@ahmedlhanafy
Copy link

Are there any plans to add support for React Native in the future?

@maxence-machu
Copy link

maxence-machu commented Jun 11, 2018

+1, nice projet by the way

@alioguzhan
Copy link

alioguzhan commented Jun 11, 2018

Since integration is being done at native level, we should be able to use this tool for React-Native projects as well. Just update related files under ios and android projects. (default react native apps, not expo!)

@trungtin
Copy link

trungtin commented Jun 12, 2018

If trying to add this pod 'Yoga','~>1.8.1', :modular_headers => true to the Podfile we stuck on #30. And when trying to install Yoga from podspec like this:

pod 'Yoga', :podspec => 'https://raw.githubusercontent.com/facebook/yoga/50e3714b21437d244e51874435953a2d011d1618/Yoga.podspec', :modular_headers => true

We stumble upon this issue The 'Pods-xxx' target has libraries with conflicting names: libyoga.a. as indeed in our Podfile we already have this:

pod "yoga", :path => "#{react_native_path}/ReactCommon/yoga"

Any idea :D?

@carloscuesta
Copy link

React Native support would be awesome!

@danielbuechele
Copy link
Contributor

I agree! React Native support is something we should look into. From my understanding the actual views created by React Native should already show up in the layout inspector. What we could offer, is adding React Dev Tools to Sonar as a separate plugin, showing the React components. Linking between the layout inspector with the actual views and a React plugin showing the component tree would be great.

The biggest task I see with this project, is to send the component hierarchy to the desktop. We will need to create a connection from JS to the desktop app.

@danielbuechele danielbuechele added JS enhancement New feature or request labels Jun 12, 2018
@NSExceptional
Copy link

It isn't usually useful to inspect React Native views. There are no unique class names so everything looks the same when it's in a flat list. Not great for debugging.

That's my experience using FLEX on a RN app, anyway...

@koox00
Copy link

koox00 commented Jun 14, 2018

Even without the React devtools having a network inspector in a React native app is a great feat!

@kashishgrover
Copy link

Looking forward to this! Thanks 😄

@sregg
Copy link

sregg commented Aug 14, 2018

https://github.com/infinitered/reactotron works very well with React Native.
It offers network inspection, better stack traces and redux actions/state logging and replay.
Checkout this video for more details: https://www.youtube.com/watch?v=UiPo9A9k7xc

@timsaval
Copy link

Our team would love that as well!

@kashishgrover
Copy link

@sregg already using it! 😄

@estevaolucas
Copy link

@axe-fb is working to make it happen 🙌.

RN 0.61.0 will come with default setup on Android. And for iOS, per discussion here facebook/react-native#26053, Yoga dependence in Layout plugin clashes with RN one's (causing a The 'Pods-xxx' target has libraries with conflicting names: libyoga.a) and it should get fixed with those two commits: facebook/react-native@82a8080 facebook/react-native@a58dd96. 🤞

Thanks @axe-fb!

@mateosilguero
Copy link
Contributor

I made this tutorial https://fbflipper.com/docs/getting-started.html#setup-your-react-native-app for React native integration. Currently there is no full support, but you could use some features

@freysie
Copy link

freysie commented Oct 11, 2019

Trying to get Flipper to work with RN 0.59 and ExpoKit, I’m getting that libyoga.a error. Does anyone know of some kind of Podfile workaround or must I wait until Expo ships with RN 0.61?

@TommyLeong
Copy link

Somehow the default Flipper setup on Android (RN0.61.0) does not connect my app with flipper. Guessing some dependencies weren't included on Android.

Anyway, my app has successfully integrated with Flipper following this guide. Thanks to guide from @mateosilguero !

@mweststrate
Copy link
Contributor

We are working on standardizing this, so ideally in 0.62 Flipper should work out of the box on React Native. In a later version it will also be possible to directly integrate with Flipper from the JavaScript side of things on RN.

@MakhouT
Copy link

MakhouT commented Jan 20, 2020

Awesome!

facebook-github-bot pushed a commit that referenced this issue Mar 6, 2020
Summary:
## The dependency [p-map](https://github.com/sindresorhus/p-map) was updated from `3.0.0` to `4.0.0`.
This version is **not covered** by your **current version range**.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

 ---

**Publisher:** [sindresorhus](https://www.npmjs.com/~sindresorhus)
**License:** MIT

<details>
<summary>Release Notes for v4.0.0</summary>

<h3>Breaking</h3>
<ul>
<li>Require Node.js 10  <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/sindresorhus/p-map/commit/bf037695761aa3c8a54ef4efffdadff0d4cb0cd9/hovercard" href="https://urls.greenkeeper.io/sindresorhus/p-map/commit/bf037695761aa3c8a54ef4efffdadff0d4cb0cd9"><tt>bf03769</tt></a></li>
</ul>
<h3>Improvements</h3>
<ul>
<li>Ensure <code>concurrency</code> option is an integer  <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/sindresorhus/p-map/commit/b342717a9c44a2d3973b92a7cbf5eaef3a6252a2/hovercard" href="https://urls.greenkeeper.io/sindresorhus/p-map/commit/b342717a9c44a2d3973b92a7cbf5eaef3a6252a2"><tt>b342717</tt></a></li>
</ul>
<p><a class="commit-link" href="https://urls.greenkeeper.io/sindresorhus/p-map/compare/v3.0.0...v4.0.0"><tt>v3.0.0...v4.0.0</tt></a></p>
</details>

<details>
<summary>Commits</summary>
<p>The new version differs by 5 commits.</p>
<ul>
<li><a href="https://urls.greenkeeper.io/sindresorhus/p-map/commit/a4b4dec459544d98880bc53a580e53691aff9fa9"><code>a4b4dec</code></a> <code>4.0.0</code></li>
<li><a href="https://urls.greenkeeper.io/sindresorhus/p-map/commit/b342717a9c44a2d3973b92a7cbf5eaef3a6252a2"><code>b342717</code></a> <code>Ensure <code>concurrency</code> is an integer</code></li>
<li><a href="https://urls.greenkeeper.io/sindresorhus/p-map/commit/bf037695761aa3c8a54ef4efffdadff0d4cb0cd9"><code>bf03769</code></a> <code>Require Node.js 10</code></li>
<li><a href="https://urls.greenkeeper.io/sindresorhus/p-map/commit/f8ccb4e778a9f08881da8adca65b5446401c2317"><code>f8ccb4e</code></a> <code>Tidelift tasks</code></li>
<li><a href="https://urls.greenkeeper.io/sindresorhus/p-map/commit/ed1b661ae96f46ecb1d5796601b221aae779e4b9"><code>ed1b661</code></a> <code>Fix test race condition (https://github.com/facebook/flipper/issues/21)</code></li>
</ul>
<p>See the <a href="https://urls.greenkeeper.io/sindresorhus/p-map/compare/a8c06732e440214da89c410fa8d0cd74e110868e...a4b4dec459544d98880bc53a580e53691aff9fa9">full diff</a></p>
</details>

 ---

<details>
  <summary>FAQ and help</summary>

  There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>

 ---

Your [Greenkeeper](https://greenkeeper.io) bot 🌴
Pull Request resolved: #864

Reviewed By: mweststrate

Differential Revision: D20303306

Pulled By: passy

fbshipit-source-id: 0de6df2e1a9f907c88cad30f70ff35d6af0f328b
facebook-github-bot pushed a commit that referenced this issue Mar 6, 2020
Summary:
## The dependency [p-map](https://github.com/sindresorhus/p-map) was updated from `3.0.0` to `4.0.0`.
This version is **not covered** by your **current version range**.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

 ---

**Publisher:** [sindresorhus](https://www.npmjs.com/~sindresorhus)
**License:** MIT

<details>
<summary>Release Notes for v4.0.0</summary>

<h3>Breaking</h3>
<ul>
<li>Require Node.js 10  <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/sindresorhus/p-map/commit/bf037695761aa3c8a54ef4efffdadff0d4cb0cd9/hovercard" href="https://urls.greenkeeper.io/sindresorhus/p-map/commit/bf037695761aa3c8a54ef4efffdadff0d4cb0cd9"><tt>bf03769</tt></a></li>
</ul>
<h3>Improvements</h3>
<ul>
<li>Ensure <code>concurrency</code> option is an integer  <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/sindresorhus/p-map/commit/b342717a9c44a2d3973b92a7cbf5eaef3a6252a2/hovercard" href="https://urls.greenkeeper.io/sindresorhus/p-map/commit/b342717a9c44a2d3973b92a7cbf5eaef3a6252a2"><tt>b342717</tt></a></li>
</ul>
<p><a class="commit-link" href="https://urls.greenkeeper.io/sindresorhus/p-map/compare/v3.0.0...v4.0.0"><tt>v3.0.0...v4.0.0</tt></a></p>
</details>

<details>
<summary>Commits</summary>
<p>The new version differs by 5 commits.</p>
<ul>
<li><a href="https://urls.greenkeeper.io/sindresorhus/p-map/commit/a4b4dec459544d98880bc53a580e53691aff9fa9"><code>a4b4dec</code></a> <code>4.0.0</code></li>
<li><a href="https://urls.greenkeeper.io/sindresorhus/p-map/commit/b342717a9c44a2d3973b92a7cbf5eaef3a6252a2"><code>b342717</code></a> <code>Ensure <code>concurrency</code> is an integer</code></li>
<li><a href="https://urls.greenkeeper.io/sindresorhus/p-map/commit/bf037695761aa3c8a54ef4efffdadff0d4cb0cd9"><code>bf03769</code></a> <code>Require Node.js 10</code></li>
<li><a href="https://urls.greenkeeper.io/sindresorhus/p-map/commit/f8ccb4e778a9f08881da8adca65b5446401c2317"><code>f8ccb4e</code></a> <code>Tidelift tasks</code></li>
<li><a href="https://urls.greenkeeper.io/sindresorhus/p-map/commit/ed1b661ae96f46ecb1d5796601b221aae779e4b9"><code>ed1b661</code></a> <code>Fix test race condition (https://github.com/facebook/flipper/issues/21)</code></li>
</ul>
<p>See the <a href="https://urls.greenkeeper.io/sindresorhus/p-map/compare/a8c06732e440214da89c410fa8d0cd74e110868e...a4b4dec459544d98880bc53a580e53691aff9fa9">full diff</a></p>
</details>

 ---

<details>
  <summary>FAQ and help</summary>

  There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>

 ---

Your [Greenkeeper](https://greenkeeper.io) bot 🌴
Pull Request resolved: #865

Reviewed By: mweststrate

Differential Revision: D20303303

Pulled By: passy

fbshipit-source-id: a5c553e559d28f32e2254a9dfa7a19069e39e9fb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request JS
Projects
None yet
Development

No branches or pull requests