Flipper 0.126 crashing metro

[artstylee]

🐛 Bug Report

after installing flipper 0.126 my metro crashing every time with an error

D:\docs\proj\react-express-jwt-full\motoNative\node_modules\metro-he
rmes-compiler\src\emhermesc.js:77
          throw ex;
          ^

TypeError: Cannot read properties of undefined (reading 'startsWith'
)

Environment

WIN 10

[mweststrate]

This should be fixable by changing node_modules/@react-native-community/cli-server-api/build/websocket/eventSocketServer.js line 131 from return origin.startsWith('http://localhost:') || origin.startsWith('file:'); to return !origin || origin.startsWith('http://localhost:') || origin.startsWith('file:');.

I'll try to submit a PR for that when back from PTO, or feel free to submit a PR already at https://github.com/react-native-community/cli/blob/master/packages/cli-server-api/src/websocket/eventsSocketServer.ts#L129. You can solve the issue locally by using patch-package

[ghost]

Faced with this issue too, downgrading Flipper to 0.125 will fix it

[artstylee]

ye i downgrade too

[realtril]

@davydspotnana @artstylee how did you downgrade a flipper? I mean, how can I downgrade the desktop app?

[sytolk]

the same issue on Mac

info Opening flipper://null/Hermesdebuggerrn?device=React%20Native...
/Users/sytolk/IdeaProjects/drivefuel-app/DriveApp/node_modules/metro-hermes-compiler/src/emhermesc.js:77
          throw ex;
          ^

TypeError: Cannot read property 'startsWith' of undefined
    at Object.verifyClient (/Users/sytolk/IdeaProjects/drivefuel-app/DriveApp/node_modules/@react-native-community/cli-server-api/build/websocket/eventsSocketServer.js:131:21)
    at WebSocketServer.handleHybiUpgrade (/Users/sytolk/IdeaProjects/drivefuel-app/DriveApp/node_modules/ws/lib/WebSocketServer.js:331:28)
    at WebSocketServer.handleUpgrade (/Users/sytolk/IdeaProjects/drivefuel-app/DriveApp/node_modules/ws/lib/WebSocketServer.js:173:26)
    at Server.WebSocketServer._onServerUpgrade (/Users/sytolk/IdeaProjects/drivefuel-app/DriveApp/node_modules/ws/lib/WebSocketServer.js:89:12)
    at Server.emit (events.js:412:35)
    at onParserExecuteCommon (_http_server.js:700:14)
    at onParserExecute (_http_server.js:613:3)
Process terminated. Press <enter> to close the window

downgrade here: https://github.com/facebook/flipper/releases

[realtril]

@sytolk thank you!

[renchap]

@mweststrate I have been able to test your fix and it works.

I can make a PR, but I am not sure this is the best issue as this check is here for security reasons, and allowing empty origins could be an issue.

[nikoden-io]

Thanks @mweststrate ! Your solution works for me
EDIT: the fix works but need repeated modification, don't have find yet what update this file on my project

[amirping]

+1

[ghost]

Happens on MacOS with Apple Silicon as well.

[mweststrate]

Should be fixed in Flipper 0.127 which will ship later today, and/or in the next version of RN

[fergalmoran]

I'm not sure this is a duplicate of #1523 ? I downgraded to 0.125.0 then upgraded to 0.127.0 but none of them fixed my issue.
Flipper connects to my device but the hermes plugin is disabled.

Device plugin 'Hermes Debugger (RN)' is not supported by the selected device 'Pixel_5_API_30' (Android).```