Use QPL-managed QPLCore and PigeonClient #1612
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: * Use the QPL-managed QPLCore and PigeonClient. **Facebook:** js-shared/qpl and js-shared/pigeon-client are maintained by QPL in xplat/js-shared. I've updated the Metro config and tsconfig to allow the packages to be imported without breaking the open-source version. Reviewed By: passy Differential Revision: D24358369 fbshipit-source-id: ebccd76ee3f645e3a06f23daee4c46281ca3c4cd
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D24358369 |
Pull Request Test Coverage Report for Build 323973752
💛 - Coveralls |
passy
approved these changes
Oct 23, 2020
passy
approved these changes
Oct 23, 2020
|
This pull request has been merged in 8a31e98. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Reviewed By: passy
Differential Revision: D24358369