Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[actions] Create issue on publish failure #2904

Closed
wants to merge 5 commits into from
Closed

Conversation

passy
Copy link
Member

@passy passy commented Sep 23, 2021

Summary

Because the publish runs aren't triggered on the main branch, we have limited visibility. Sending push notifications, webhooks or email integrations are hard, but opening an issue seems like a decent work-around for this.

We can broaden this to more publish actions as needed.

Test Plan

Ran on my fork which generated this issue: passy#9

@facebook-github-bot
Copy link
Contributor

@passy has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@passy has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Sep 23, 2021
@facebook-github-bot
Copy link
Contributor

@passy has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@passy has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@passy has updated the pull request. You must reimport the pull request before landing.

@passy
Copy link
Member Author

passy commented Sep 27, 2021

Rebasing so the main errors go away.

@facebook-github-bot
Copy link
Contributor

@passy has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@coveralls
Copy link

coveralls commented Sep 27, 2021

Pull Request Test Coverage Report for Build 1278053094

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 14 unchanged lines in 7 files lost coverage.
  • Overall coverage remained the same at 49.924%

Files with Coverage Reduction New Missed Lines %
desktop/app/src/sandy-chrome/appinspect/LaunchEmulator.tsx 1 59.46%
desktop/app/src/server/devices/ios/iOSContainerUtility.tsx 1 29.32%
desktop/app/src/server/FlipperServerImpl.tsx 1 21.62%
desktop/app/src/MenuBar.tsx 2 33.33%
desktop/app/src/reducers/settings.tsx 2 78.26%
desktop/test-utils/src/pathUtils.ts 2 57.14%
desktop/app/src/server/devices/ios/iOSDeviceManager.tsx 5 22.14%
Totals Coverage Status
Change from base Build 1277603633: 0.0%
Covered Lines: 6781
Relevant Lines: 12460

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants