Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kotlin upgrade 4 #3095

Closed
wants to merge 5 commits into from
Closed

Kotlin upgrade 4 #3095

wants to merge 5 commits into from

Conversation

passy
Copy link
Member

@passy passy commented Nov 24, 2021

Unblocked by the Litho upgrade.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Nov 24, 2021
@facebook-github-bot
Copy link
Contributor

@passy has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@coveralls
Copy link

coveralls commented Nov 24, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1503787837

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 13 unchanged lines in 6 files lost coverage.
  • Overall coverage remained the same at 48.477%
Files with Coverage Reduction New Missed Lines %
desktop/flipper-server-core/src/devices/ios/iOSContainerUtility.tsx 1 26.92%
desktop/flipper-server-core/src/FlipperServerImpl.tsx 1 16.24%
desktop/flipper-ui-core/src/reducers/settings.tsx 1 90.0%
desktop/flipper-ui-core/src/sandy-chrome/appinspect/LaunchEmulator.tsx 1 60.87%
desktop/test-utils/src/pathUtils.ts 2 57.14%
desktop/flipper-server-core/src/devices/ios/iOSDeviceManager.tsx 7 21.38%
Totals Coverage Status
Change from base Build 1503250842: 0.0%
Covered Lines: 7426
Relevant Lines: 13922
💛 - Coveralls

@facebook-github-bot
Copy link
Contributor

@passy has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@passy has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@passy has updated the pull request. You must reimport the pull request before landing.

1 similar comment
@facebook-github-bot
Copy link
Contributor

@passy has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@passy has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@passy
Upgrade Litho
4ac59d3 
Summary:
This unblocks a bunch of other Kotlin-related updates as Litho 0.39
forced us to use a bunch of old stuff. Also, allows us to finally drop
Jcenter.

Test Plan:
Built and ran the sample app.
@passy
Upgrade Kotlin
5d959da 
Summary:
Unblocked by the Litho upgrade.
@passy
Bump SDK to match appcompat requirement
8ebfeba
@passy
More upgrades
f936df1
@passy
JDK 11
b010b42
@facebook-github-bot
Copy link
Contributor

@passy has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@passy has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@passy merged this pull request in 8ccae8a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@passy @facebook-github-bot @coveralls