[android][sample] Disable Fresco integration for now #5101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@passy has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Pull Request Test Coverage Report for Build 6035737025
💛 - Coveralls |
passy
pushed a commit
that referenced
this pull request
Sep 19, 2023
Original commit changeset: 42b95c2
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 19, 2023
Summary: Back out "Disable Fresco integration for now (#5101)" Original commit changeset: 42b95c2 This is now working again with Fresco 3.1.0 --- Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/flipper/pull/5159). * #5160 * __->__ #5159 * #5158 Pull Request resolved: #5159 Reviewed By: antonk52 Differential Revision: D49411925 Pulled By: passy fbshipit-source-id: 34a422e60102de56fb6588e05cf4729a30e0e112
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[android][sample] Disable Fresco integration for now
Summary:
There's currently a startup crash
https://gist.github.com/passy/3f6b5935d8f9171ea0d3d915857b9786
We'll need to wait for a new Fresco release. In the meantime, let's comment this out so we can still use the rest of the app.
Stack created with Sapling. Best reviewed with ReviewStack.