Skip to content

Commit

Permalink
[easy] Do not include implicit inexact object lint in all
Browse files Browse the repository at this point in the history
Summary: Until flow-typed/flow-typed#3365 lands, there's no reasonable way for people to fix this in their libdefs. Until then, we should keep this lint explicitly opt-in.

Reviewed By: dsainati1

Differential Revision: D15716880

fbshipit-source-id: b9d0c51e52f5e1509e9d8a5da189f7c27ba8dfce
  • Loading branch information
jbrown215 authored and facebook-github-bot committed Jun 8, 2019
1 parent c72fcd5 commit 0507b3e
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
1 change: 1 addition & 0 deletions src/common/lints/lintSettings.ml
Expand Up @@ -29,6 +29,7 @@ let ignored_by_all = [
Lints.DynamicExport;
Lints.DeprecatedUtility;
Lints.DeprecatedEnumUtility;
Lints.ImplicitInexactObject;
]

let config_default =
Expand Down
6 changes: 6 additions & 0 deletions tests/lint_all_warn/implicit-inexact-object.js
@@ -0,0 +1,6 @@
//@flow

// Implicit inexact object lints are not included in all until
// https://github.com/flow-typed/flow-typed/pull/3365 lands

type X = {}; // No error

0 comments on commit 0507b3e

Please sign in to comment.