Cannot resolve JSON file starting with a dot

[mrtnzlml]

Flow version:

version 0.97.0

Flow cannot resolve require with JSON filename starting with a dot:

const meta = require('../.meta.json');

It results in this error:

Error ┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈ src/apps/graphql-skymock/datasets/__tests__/MetafileConsistency.test.js:7:22

Cannot resolve module ../.meta.json.

      4│ import path from 'path';
      5│ import Ajv from 'ajv';
      6│
      7│ const meta = require('../.meta.json');
      8│
      9│ test('every dataset defined in metafile should exist', () => {
     10│   expect.hasAssertions();

However, when I remove the dot (and rename the file) everything is fine:

const meta = require('../meta.json');

No errors!

Thank you very much for checking it! :)

[mrtnzlml]

This is true even for JS files (.meta.js).

[goodmind]

Yeah, Flow ignores all dotfiles, it probably should check if they have extension .meta vs .meta.js

[mrtnzlml]

Can I opt-out from this? I know it's unusual to start with a dot so it's not very common but it really makes sense in my case. Why does Flow ignore dot files by default?

[goodmind]

No idea, it also wouldn't work with [include]

[goodmind]

Maybe you can try symlinks

[gabrielrumiranda]

Hi, can I work on this ?

[goodmind]

@gabrielrumiranda Sure you can, what you want to know about codebase?

[gabrielrumiranda]

@goodmind is my first contribution in project, i don't know much about codebase. The module who works with imports is flow/src/typing/import_export.ml ?

[goodmind]

@gabrielrumiranda

flow/src/common/files.ml

Lines 97 to 102 in 95ef246

	fun ~options ->
	let file_exts = get_all_watched_extensions options in
	fun path ->
	let basename = Filename.basename path in
	not (is_dot_file basename) && (check_ext file_exts basename || basename = "package.json")

This should be here I think

[gabrielrumiranda]

@goodmind the tests of this part of code is in tests/declarations_files_node ?

[goodmind]

Not sure where the tests should be, maybe new folder?

[gabrielrumiranda]

I create a PR, #8045