Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot call assert.rejects because property rejects is missing in object type [1] #8269

Open
JSRossiter opened this issue Jan 17, 2020 · 2 comments
Labels
Library definitions Issues or pull requests about core library definitions

Comments

@JSRossiter
Copy link

Missing/Incorrect APIs

Node assert is missing a few method definitions:

  • rejects
  • doesNotReject
  • match
  • doesNotMatch

Relevant documentation

https://nodejs.org/api/assert.html

@JSRossiter JSRossiter added the Library definitions Issues or pull requests about core library definitions label Jan 17, 2020
@danny-does-stuff
Copy link

I would be interested in working on this! Any pointers on how to get started would be awesome 👍

@JSRossiter
Copy link
Author

The changes that need to be added are here https://github.com/facebook/flow/blob/master/lib/node.js#L2467 and docs for the methods are at https://nodejs.org/api/assert.html. The existing definitions should serve as a decent example of what needs to be added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Library definitions Issues or pull requests about core library definitions
Projects
None yet
Development

No branches or pull requests

2 participants