Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Array.pop should return a maybe type #8341

Open
amccloud opened this issue Apr 6, 2020 · 0 comments
Open

Array.pop should return a maybe type #8341

amccloud opened this issue Apr 6, 2020 · 0 comments
Labels
bug needs triage

Comments

@amccloud
Copy link

amccloud commented Apr 6, 2020 •
edited

Flow version: v0.122.0

Expected behavior

Array.pop should behave like typescript pop(): ?T

https://www.typescriptlang.org/play?#code/MYewdgzgLgBAhjAvDA2gRgDQCYMGYC6A3AFDEDuAFgJYA2ApjABRQBOArnQJQwDexMMUJFgAjJPAB0ABxBTGnEgKEQQ9CTRABzRmIBUMEQuIBfIA

Actual behavior

Array.pop always returns a value pop(): T

https://flow.org/try/#0MYewdgzgLgBAhjAvDA2gRgDQCYMGYC6A3AFDEDuAFgJYA2ApjABRQBOArnQJQwDexMMUJFgAjJPAB0ABxBTGnEgKEQQ9CTRABzRmIBUMEQuIBfIA

You can also replicate the typescript error above by explicitly adding a null terminator or annotate number as ?number
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug needs triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@amccloud