Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

RECEIVE_RAW_CREATED_MESSAGE event is never handled #32

Closed
coodoo opened this issue Aug 15, 2014 · 8 comments
Closed

RECEIVE_RAW_CREATED_MESSAGE event is never handled #32

coodoo opened this issue Aug 15, 2014 · 8 comments

Comments

@coodoo
Copy link

coodoo commented Aug 15, 2014

Just wondering what happens when RECEIVE_RAW_CREATED_MESSAGE was dispatched, currently in the code base it was not handled anywhere.

Also, what if ChatWebAPIUtils.createMessage() received error from the XHR call to server, what happens next? Should the data already in Stores and Views be rolled back?

@coodoo coodoo changed the title RECEIVE_RAW_CREATED_MESSAGE RECEIVE_RAW_CREATED_MESSAGE event is never handled Aug 15, 2014
@troybetz
Copy link

Assuming you're using Browserify, is the Store handling that action actually being require'd by a component or anything?

@fisherwebdev
Copy link
Contributor

Please see: https://groups.google.com/forum/#!topic/reactjs/kaQBbTqEj_s

Not sure I can implement this without increasing the complexity to the point where it may cause more harm than good. But I will look into fleshing this out more.

@fisherwebdev
Copy link
Contributor

That is, I want to keep the example simple and easy to understand.

@coodoo
Copy link
Author

coodoo commented Aug 16, 2014

Thanks, please feel free to close this issue.

@mczepiel
Copy link

FWIW, even if you only implement the happy path acceptance of the "confirmed" message I think it would make this example feel more complete. Right now the complete absence of any handler for this action led me to hunt around to see if I was missing something.

A comment about the RECEIVE_RAW_CREATED_MESSAGE_FAILURE being left as an exercise for the reader would be fine but I don't think closing the loop of accepting the confirmed message from the "server" would over complicate this.

I could take care of that for you with a PR but I have another related question I posted on the google group where I need some clarification.

@sharathprabhal
Copy link

+1

@ghost
Copy link

ghost commented Aug 5, 2015

Thank you for reporting this issue and appreciate your patience. We've notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed.

@kyldvs
Copy link
Contributor

kyldvs commented Nov 18, 2015

Looks like original issue is resolved so closing this out. If there is a specific aspect of the example you feel could be improved (such as adding a comment) a PR would be great.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants