Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

Please add it to bower. Maybe without the need for any dependencies on npm/node? #61

Closed
totty90 opened this issue Sep 17, 2014 · 10 comments

Comments

@totty90
Copy link

totty90 commented Sep 17, 2014

No description provided.

@briandipalma
Copy link

bower depends on both npm and node...

@totty90
Copy link
Author

totty90 commented Sep 18, 2014

What is the problem with that?

@briandipalma
Copy link

Well how can something that uses bower not depend on node/npm?

@totty90
Copy link
Author

totty90 commented Sep 18, 2014

Just publish it to bower... I don't understand what is so complicated about that. Why do you care whenever bower depends on node/npm? It doesn't matter.

@zpao
Copy link
Contributor

zpao commented Sep 19, 2014

"publishing" to bower actually means we need to keep compiled files in the repo. That might not be the worst thing, but is the exact reason we actually maintain a separate repo with builds for React (https://github.com/facebook/react-bower). It's not as simple as publishing compiled files to npm.

@briandipalma Please take it elsewhere. Yes, I mostly agree that bower is silly for how I build sites, but it serves a slightly different purpose than npm, even if it depends on node/npm. So let's respect the people who use it.

@fisherwebdev I think we could do this. I would probably just say have a dist folder and only add the Flux.js file there when we tag version updates (bower depends on git tags), rejecting other changes to that file. If you're interested, let's chat and iron it out.

@totty90
Copy link
Author

totty90 commented Sep 19, 2014

Thanks for your attention.

@Aaronik
Copy link

Aaronik commented Sep 19, 2014

+1

It'd be great to see this in bower. My team uses bower for our client code and if absolutely nothing else, this would make it even easier to bring into our projects.

Plus there's the fact that React is in bower, so publishing it there would allow us to keep our dependencies clean cleaner ;)

@fisherwebdev
Copy link
Contributor

Done. bower install flux will give you bower_components/flux/dist/Flux.js, which if you add to your page will give you a global Flux object. Flux.dispatcher is your dispatcher.

@totty90
Copy link
Author

totty90 commented Sep 22, 2014

Thanks, Bill (:

@upchuk
Copy link

upchuk commented Feb 12, 2015

@fisherwebdev That's cool. Maybe it would be worth putting that in the docs (readme) as well? :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants