Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

Dont use require('react/lib/*') in examples & docs #77

Closed
zpao opened this issue Oct 10, 2014 · 4 comments
Closed

Dont use require('react/lib/*') in examples & docs #77

zpao opened this issue Oct 10, 2014 · 4 comments

Comments

@zpao
Copy link
Contributor

zpao commented Oct 10, 2014

These are internal and implementation details of how React builds for npm. We're going to deprecate them. merge is now simply Object.assign and copyProperties is a simple for in (and can be replaced with Object.assign)

@justinwoo
Copy link
Contributor

What's your position on this now, with the release of 0.12 with deprecation warnings for merge/copyProperties and the provision of Object.assign in react/lib? Is it okay for the examples to simply be updated to use react/lib/Object.assign instead, or will even that be very quickly moved out of React entirely?

@fisherwebdev
Copy link
Contributor

My understanding is that FB is working on exposing Object.assign in a way that can be shared across projects, not just within React. But we're not there yet. So I am thinking about using Sindre's npm module for Object.assign until then.

@justinwoo
Copy link
Contributor

Cool, I'll look into updating my PR sometime later. It'd also be nice if we could also get Invariant to be shared when things are being bundled up.

@justinwoo
Copy link
Contributor

Done: #91

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants