Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

Test variables missing var keyword #80

Closed
jim-y opened this issue Oct 12, 2014 · 2 comments
Closed

Test variables missing var keyword #80

jim-y opened this issue Oct 12, 2014 · 2 comments

Comments

@jim-y
Copy link
Contributor

jim-y commented Oct 12, 2014

In TodoStore-test.js the variables at lines 37-39 are missing var, and i think they are going global

beforeEach(function() {
  AppDispatcher = require('../../dispatcher/AppDispatcher');
  TodoStore = require('../TodoStore');
  callback = AppDispatcher.register.mock.calls[0][0];
});

Not a big deal though :)

@fisherwebdev
Copy link
Contributor

Yeah, we should hoist the original declaration of those variables out to the closure of the describe() function. Please submit a pull request, if you want, or I can get to it when I can.

@fisherwebdev
Copy link
Contributor

Thanks for taking care of this!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants