Skip to content

Commit

Permalink
Fix CMake commands in README
Browse files Browse the repository at this point in the history
Summary:
Remove bogus `configure` argument from cmake commands which is likely an
artefact from automake migration. The correct invocation of CMake is

```
cmake [<options>] {<path-to-source> | <path-to-existing-build>}
```

Reviewed By: Orvid

Differential Revision: D9721030

fbshipit-source-id: 95da844d3292cbf2acbec85753499f3603567e08
  • Loading branch information
vitaut authored and facebook-github-bot committed Sep 7, 2018
1 parent 5de46e4 commit 5bb6b0a
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions README.md
Expand Up @@ -83,7 +83,7 @@ wget https://github.com/google/googletest/archive/release-1.8.0.tar.gz && \
tar zxf release-1.8.0.tar.gz && \
rm -f release-1.8.0.tar.gz && \
cd googletest-release-1.8.0 && \
cmake configure . && \
cmake . && \
make && \
make install
```
Expand All @@ -96,12 +96,12 @@ variables to make CMAKE look also look for header files and libraries in
non-standard locations. For example, to also search the directories
`/alt/include/path1` and `/alt/include/path2` for header files and the
directories `/alt/lib/path1` and `/alt/lib/path2` for libraries, you can invoke
`cmake configure` as follows:
`cmake` as follows:

```
cmake configure \
cmake \
-DCMAKE_INCLUDE_PATH=/alt/include/path1:/alt/include/path2 \
-DCMAKE_LIBRARY_PATH=/alt/lib/path1:/alt/lib/path2
-DCMAKE_LIBRARY_PATH=/alt/lib/path1:/alt/lib/path2 ...
```

#### Ubuntu 16.04 LTS
Expand Down Expand Up @@ -142,7 +142,7 @@ sudo apt-get install \
In the folly directory, run:
```
mkdir _build && cd _build
cmake configure ..
cmake ..
make -j $(nproc)
make install
```
Expand Down Expand Up @@ -216,7 +216,7 @@ You may also use `vcpkg install folly:x64-windows --head` to build against `mast
[double-conversion/] `ln -s src double-conversion`

[folly/] `mkdir build && cd build`
[folly/build/] `cmake configure "-DCMAKE_INCLUDE_PATH=$DOUBLE_CONVERSION_HOME/include" "-DCMAKE_LIBRARY_PATH=$DOUBLE_CONVERSION_HOME/lib" ..`
[folly/build/] `cmake "-DCMAKE_INCLUDE_PATH=$DOUBLE_CONVERSION_HOME/include" "-DCMAKE_LIBRARY_PATH=$DOUBLE_CONVERSION_HOME/lib" ..`

[folly/build/] `make`

Expand Down

0 comments on commit 5bb6b0a

Please sign in to comment.