Skip to content

Commit

Permalink
Try to fix Fingerprint on Apple Clang 9.0
Browse files Browse the repository at this point in the history
Summary: As per #961, it appears that Apple Clang takes issue with modifying const values in the constructor within a constexpr context.

Reviewed By: yfeldblum

Differential Revision: D13005049

fbshipit-source-id: b0c9efcb6c5c4667028a7e0948e2fac53afdb1d2
  • Loading branch information
Orvid authored and facebook-github-bot committed Nov 11, 2018
1 parent 97af747 commit 613f048
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion folly/Fingerprint.cpp
Expand Up @@ -83,7 +83,7 @@ constexpr auto copy_table(D const (&table)[S0][S1][S2]) {

template <size_t Deg>
constexpr poly_table<Deg> make_poly_table() {
FingerprintPolynomial<Deg> const poly(FingerprintTablePoly<Deg>::data);
FingerprintPolynomial<Deg> poly(FingerprintTablePoly<Deg>::data);
uint64_t table[8][256][poly_size(Deg)] = {};
// table[i][q] is Q(X) * X^(k+8*i) mod P(X),
// where k is the number of bits in the fingerprint (and deg(P)) and
Expand Down

0 comments on commit 613f048

Please sign in to comment.