Add sorted_vector_set::const_pointer (#1987)

Summary: Pull Request resolved: #1987 similarly, `std::set` has const_pointer Reviewed By: swolchok Differential Revision: D45194122 fbshipit-source-id: 5ad1b7c40fb21a92333603d804ee2e3f16c78f27
facebook · Apr 22, 2023 · e3b9b1e · e3b9b1e
1 parent fc8514e
commit e3b9b1e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/folly/sorted_vector_types.h b/folly/sorted_vector_types.h
@@ -271,6 +271,7 @@ class sorted_vector_set : detail::growth_policy_wrapper<GrowthPolicy> {
   typedef typename Container::pointer pointer;
   typedef typename Container::reference reference;
   typedef typename Container::const_reference const_reference;
+  typedef typename Container::const_pointer const_pointer;
   /*
    * XXX: Our normal iterator ought to also be a constant iterator
    * (cf. Defect Report 103 for std::set), but this is a bit more of a

diff --git a/folly/test/sorted_vector_test.cpp b/folly/test/sorted_vector_test.cpp
@@ -65,6 +65,9 @@ static_assert(!folly::is_sorted_vector_set_v<std::set<int>>);
 static_assert(!folly::is_sorted_vector_set_v<std::unordered_set<int>>);
 static_assert(!folly::is_sorted_vector_set_v<std::vector<int>>);
 
+static_assert(
+    std::is_same_v<folly::sorted_vector_set<int>::const_pointer, const int*>);
+
 static_assert(std::is_same_v<
               folly::sorted_vector_map<int, double>::pointer,
               std::pair<int, double>*>);