-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests fail to compile: error: 'auto' not allowed in function prototype #2032
Comments
It seems the usage is allowed in cpp20. |
any update on this? |
I've put up a change internally to change this to:
Which should resolve the issue by supporting compiling against things before C++20. I hope to land it soon. |
in c++ versions 14,17 and 20 on gcc v9 you can use the auto type for function prototypes. But you will have the warning : \main.cpp [Warning] use of 'auto' in parameter declaration only available with '-fconcepts' this warning can also be suppressed by the -w parameter |
Clang always prints an error in this case. |
Oh😮 this is intersting!? |
Summary: We're not yet to the point where we can blindly use C++20 features unguarded yet, so switch this to a normal template parameter Fixes: facebook#2032 Reviewed By: DenisYaroshevskiy Differential Revision: D47345349 fbshipit-source-id: 9aff6e757f78b8b549bc4ee5b9e87be43499629a
#2039 should fix this when it lands. |
Summary: X-link: facebook/folly#2039 We're not yet to the point where we can blindly use C++20 features unguarded yet, so switch this to a normal template parameter Fixes: facebook/folly#2032 Reviewed By: DenisYaroshevskiy Differential Revision: D47345349 fbshipit-source-id: 2b80f439edcee020aaefed30022a8057327c17f3
Version: 2023.06.26.00
clang-15
FreeBSD 13.2
The text was updated successfully, but these errors were encountered: