Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler cannot found crashOnError : 'crashOnError_' was not declared in this scope #51

Closed
rchatsiri opened this issue Mar 9, 2014 · 2 comments

Comments

@rchatsiri
Copy link

I tried to change crashOnError to above public type, but cannot build source successes.

Fomatter{ 
private:
bool crashOnError_{true}; 
public:
...

};

Thus, Source retrieve to old state of source code. An error show as below:

In file included from /usr/include/c++/4.6/ext/hash_set:61:0,
                 from .././folly/String.h:25,
                 from .././folly/Format.h:36,
                 from .././folly/dynamic-inl.h:25,
                 from .././folly/dynamic.h:522,
                 from json.h:44,
                 from Benchmark.cpp:21:
/usr/include/c++/4.6/backward/backward_warning.h:33:2: warning: #warning This file includes at least one deprecated or antiquated header which may be removed without further notice at a future date. Please use a non-deprecated interface with equivalent functionality instead. For a listing of replacement headers and interfaces, consult the file backward_warning.h. To disable this warning use -Wno-deprecated. [-Wcpp]
In file included from .././folly/dynamic-inl.h:25:0,
                 from .././folly/dynamic.h:522,
                 from json.h:44,
                 from Benchmark.cpp:21:
.././folly/Format.h:159:8: error: function definition does not declare parameters
.././folly/Format.h: In member function 'void folly::Formatter<containerMode, Args>::setCrashOnError(bool)':
.././folly/Format.h:76:5: error: 'crashOnError_' was not declared in this scope
In file included from .././folly/Format.h:358:0,
                 from .././folly/dynamic-inl.h:25,
                 from .././folly/dynamic.h:522,
                 from json.h:44,
                 from Benchmark.cpp:21:
.././folly/Format-inl.h: In member function 'void folly::Formatter<containerMode, Args>::handleFormatStrError() const':
.././folly/Format-inl.h:152:7: error: 'crashOnError_' was not declared in this scope
@ghost
Copy link

ghost commented Apr 7, 2015

Thank you for reporting this issue and appreciate your patience. We've notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed.

@ghost
Copy link

ghost commented May 7, 2015

Thank you for your patience. After 30 days with no updates from the core team, we're closing out the issue. If you're still experiencing the problem described, please reopen the issue - thanks!

@ghost ghost closed this as completed May 7, 2015
facebook-github-bot pushed a commit that referenced this issue Oct 17, 2018
fbshipit-source-id: 6df047bf7833fe622b6c9901912b8022e485a610
sandraiser pushed a commit to sandraiser/folly that referenced this issue Mar 4, 2019
fbshipit-source-id: 6df047bf7833fe622b6c9901912b8022e485a610
facebook-github-bot pushed a commit that referenced this issue Jun 3, 2020
Summary:
Typo in python shebang introduced by 0d19e27, probably by accident.

Found while skimming the code.
Pull Request resolved: facebook/openr#51

Reviewed By: steven1327

Differential Revision: D21865922

Pulled By: saifhhasan

fbshipit-source-id: 5f2c2c2fac82078070920915812139f5fef1c7fe
facebook-github-bot pushed a commit that referenced this issue Sep 18, 2020
…deps and use them in tests (#51)

Summary:
Pull Request resolved: facebook/sapling#51

This diff extends capabilities of CargoBuilder in getdeps so that individual manifests can be build even without workspaces. Thanks to that a build for edenapi/tools can be made and its artifacts can be used in mononoke integration tests.

Reviewed By: StanislavGlebik

Differential Revision: D23574887

fbshipit-source-id: 8a974a6b5235d36a44fe082aad55cd380d84dd09
dotconnor pushed a commit to 5448C8/folly that referenced this issue Mar 19, 2021
Summary:
Typo in python shebang introduced by 0d19e27, probably by accident.

Found while skimming the code.
Pull Request resolved: facebook/openr#51

Reviewed By: steven1327

Differential Revision: D21865922

Pulled By: saifhhasan

fbshipit-source-id: 5f2c2c2fac82078070920915812139f5fef1c7fe
dotconnor pushed a commit to 5448C8/folly that referenced this issue Mar 19, 2021
…deps and use them in tests (facebook#51)

Summary:
Pull Request resolved: facebook/sapling#51

This diff extends capabilities of CargoBuilder in getdeps so that individual manifests can be build even without workspaces. Thanks to that a build for edenapi/tools can be made and its artifacts can be used in mononoke integration tests.

Reviewed By: StanislavGlebik

Differential Revision: D23574887

fbshipit-source-id: 8a974a6b5235d36a44fe082aad55cd380d84dd09
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant