New folly_test_util library for functions used by other projects #1071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LogDevice uses DeterministicSchedule and JsonTestUtil from Folly make these available in the installed library targets so that LogDevice can compile against installed folly rather than referencing sources directly. Test Plan: With local mods to logdevice to remove direct source inclusion, compile against newly exported libraries.
There was a problem hiding this comment.
@calebmarchent has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@calebmarchent merged this pull request in 4b05ef5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LogDevice uses DeterministicSchedule and JsonTestUtil from Folly make
these available in the installed library targets so that LogDevice can
compile against installed folly rather than referencing sources
directly.
Test Plan:
With local mods to logdevice to remove direct source inclusion, compile
against newly exported libraries.