Fix sorted_vector PMR test cases #1207
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
folly::detail::std_pmr uses either std::pmr or std::experimental::pmr. Polymorphic Memory Resources has been standardized in C++17, but pmr::resource_adaptor was left behind (cplusplus/papers#33), which means resource_adaptor is not available when a C++17 ready standard library is detected by folly. This commit reimplements test_resource without using the non-standard adaptor.
There was a problem hiding this comment.
@yfeldblum has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@yfeldblum merged this pull request in 74f346e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
folly::detail::std_pmruses eitherstd::pmrorstd::experimental::pmr."Polymorphic Memory Resources" has been standardized in C++17, but
pmr::resource_adaptorwas left behind, which meansresource_adaptoris not available when a C++17 ready standard library is detected by folly.This commit reimplements
test_resourcewithout using the non-standard adaptor.