FreeBSD build fix proposal. #1352
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yfeldblum
reviewed
Apr 13, 2020
| @@ -26,6 +26,10 @@ | |||
| #endif | |||
| #endif // FOLLY_MOBILE | |||
|
|
|||
| #if defined(__FreeBSD__) | |||
| #define FOLLY_ASSUME_NO_TCMALLOC 1 | |||
There was a problem hiding this comment.
This is supposed to be an override.
There was a problem hiding this comment.
it was to make it handier for the FreeBSD package
folly/memory/Malloc.h
Outdated
| @@ -145,6 +141,10 @@ inline bool getTCMallocNumericProperty(const char* name, size_t* out) noexcept { | |||
| return true; | |||
| } | |||
| #else | |||
| inline bool getTCMallocNumericProperty(const char* name, size_t* out) noexcept { | |||
| return MallocExtension_Internal_GetNumericProperty(name, strlen(name), out); | |||
There was a problem hiding this comment.
This weak symbol should always be present - folly declares it -, even if it does not link to anything.
There was a problem hiding this comment.
not the case unfortunately but anyway only called within this context.
There was a problem hiding this comment.
Is it a problem to declare these weak symbols also on freebsd?
no tcmalloc support on FreeBSD.
devnexen
force-pushed
the
fbsd_build_fix_no_tcmalloc
branch
from
28d2f90
to
98db52d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no tcmalloc support on FreeBSD.