io_uring: implement io_uring_enable_rings locally #1915
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: io_uring_enable_rings was missing from liburing upstream (see axboe/liburing#773) which is breaking the open source build. See facebook#1908 Instead just implement it locally, as it's trivial Differential Revision: D42497664 fbshipit-source-id: a04af7edf5cce2c98dc4d83ea329f6b34f63bef0
|
This pull request was exported from Phabricator. Differential Revision: D42497664 |
|
This pull request has been merged in 259c9d6. |
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Jan 16, 2023
Summary: X-link: facebook/folly#1915 io_uring_enable_rings was missing from liburing upstream (see axboe/liburing#773) which is breaking the open source build. See facebook/folly#1908 Instead just implement it locally, as it's trivial Reviewed By: dmm-fb Differential Revision: D42497664 fbshipit-source-id: 7241785a36046e867f907bfe74623aaeb38c4b70
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
io_uring_enable_rings was missing from liburing upstream (see axboe/liburing#773) which is breaking the open source build. See #1908
Instead just implement it locally, as it's trivial
Differential Revision: D42497664