update disable ubsan macro #1992
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Orvid has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Hi @Orvid, could you merge this into the main branch if everything looks good? Thanks! |
|
Yep, working on it. This PR got lost in my pile of things to do. It should hopefully be merged either later today or on monday. |
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Jul 28, 2023
Summary:
no_sanitize attribute now supports undefined-behavior sanitizers including `no_sanitize("unsigned-integer-overflow")`, `no_sanitize("undefined")` etc.
In the current code, running `__attribute__((no_sanitize("unsigned-integer-overflow")))` for ASan, MSan, or TSan is enabled leads to the warnings for attribute ignored. The logic here is hence incorrect. This kind of an attribute should be used only when UBSan is enabled.
X-link: facebook/folly#1992
Reviewed By: yfeldblum, Gownta
Differential Revision: D45674502
fbshipit-source-id: 97be9e9de82a546e553ed8866fb106e2f096709d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no_sanitize attribute now supports undefined-behavior sanitizers including
no_sanitize("unsigned-integer-overflow"),no_sanitize("undefined")etc.In the current code, running
__attribute__((no_sanitize("unsigned-integer-overflow")))for ASan, MSan, or TSan is enabled leads to the warnings for attribute ignored. The logic here is hence incorrect. This kind of an attribute should be used only when UBSan is enabled.