fix: drop std::unexpected_handler code removed in C++17 #2196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was deprecated in C++11 and has been removed in C++17. Now that folly requires C++17, this code can be dropped. This code prevented folly from building with (at least) libstdc++ and `-std=c++23`.
|
@Orvid has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
May 23, 2024
Summary: This was deprecated in C++11 and has been removed in C++17. Now that folly requires C++17, this code can be dropped. This code prevented folly from building with (at least) libstdc++ and `-std=c++23`. X-link: facebook/folly#2196 Reviewed By: yfeldblum, Gownta Differential Revision: D57304031 Pulled By: Orvid fbshipit-source-id: 6262110830eef67bf316622eba6902b3ca8cceb8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was deprecated in C++11 and has been removed in C++17. Now that folly requires C++17, this code can be dropped. This code prevented folly from building with (at least) libstdc++ and
-std=c++23.