fix bootstrap on osx #513
fix bootstrap on osx #513
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions. |
|
@facebook-github-bot CLA signed !! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Pulled this branch and attempted to compile using the bootstrap-osx-homebrew.sh script and things still didn't work. It appears as though the configure script fails when running through one of its checks. |
* include all dependencies * update `autoconf` & `configure` with correct params * include `make` & `make install` in the bootstrap for a better user experience * fixes facebook#332
|
@RBlafford I've fixed the script to ensure |
|
@Orvid has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@Orvid Any review comments? |
| # install deps | ||
| install_deps() { | ||
| # folly deps | ||
| dependencies=(autoconf automake libtool pkg-config double-conversion glog gflags boost libevent xz snappy lz4 jemalloc openssl) |
There was a problem hiding this comment.
@yfeldblum:
Would prefer to have this split across lines, one entry per line.
| popd | ||
|
|
||
| # make, test, install | ||
| make |
There was a problem hiding this comment.
@yfeldblum:
Seems likemake checkis missing?
|
Only a couple of minor things, but otherwise it looks good! |
autoconf&configurewith correct paramsmake&make installin the bootstrap for a better user experience