Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setProgressiveRenderingEnabled(true) gives error when decoding image #822

Closed
eldk opened this issue Dec 9, 2015 · 5 comments
Closed

setProgressiveRenderingEnabled(true) gives error when decoding image #822

eldk opened this issue Dec 9, 2015 · 5 comments
Labels
needs-details This issue or PR is currently not actionable as it misses details (e.g. for reproducing the problem)

Comments

@eldk
Copy link
Contributor

eldk commented Dec 9, 2015

Hello,
When using progressive rendering for jpeg in Image request, images are sometimes "flashing" and finally not shown unless a tap is done to reload it.

Remove .setProgressiveRenderingEnabled(true) in request builder remove the error and images are well rendered after first run.

error message :

AbstractDraweeController: controller 406a1ac0 0: final_failed @ onFailure: failure: java.lang.IllegalArgumentException

Error loading 0
java.lang.IllegalArgumentException
at com.facebook.common.internal.Preconditions.checkArgument(Preconditions.java:108)
at com.facebook.imagepipeline.memory.NativePooledByteBuffer.read(NativePooledByteBuffer.java:55)
at com.facebook.imagepipeline.platform.DalvikPurgeableDecoder.endsWithEOI(DalvikPurgeableDecoder.java:144)
at com.facebook.imagepipeline.platform.KitKatPurgeableDecoder.decodeJPEGByteArrayAsPurgeable(KitKatPurgeableDecoder.java:81)
at com.facebook.imagepipeline.platform.DalvikPurgeableDecoder.decodeJPEGFromEncodedImage(DalvikPurgeableDecoder.java:89)
at com.facebook.imagepipeline.platform.KitKatPurgeableDecoder.decodeJPEGFromEncodedImage(KitKatPurgeableDecoder.java:32)
at com.facebook.imagepipeline.decoder.ImageDecoder.decodeJpeg(ImageDecoder.java:151)
at com.facebook.imagepipeline.decoder.ImageDecoder.decodeImage(ImageDecoder.java:85)
at com.facebook.imagepipeline.producers.DecodeProducer$ProgressiveDecoder.doDecode(DecodeProducer.java:188)
at com.facebook.imagepipeline.producers.DecodeProducer$ProgressiveDecoder.access$200(DecodeProducer.java:96)
at com.facebook.imagepipeline.producers.DecodeProducer$ProgressiveDecoder$1.run(DecodeProducer.java:128)
at com.facebook.imagepipeline.producers.JobScheduler.doJob(JobScheduler.java:207)
at com.facebook.imagepipeline.producers.JobScheduler.access$000(JobScheduler.java:27)
at com.facebook.imagepipeline.producers.JobScheduler$1.run(JobScheduler.java:78)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1088)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:581)
at com.facebook.imagepipeline.core.PriorityThreadFactory$1.run(PriorityThreadFactory.java:43)
at java.lang.Thread.run(Thread.java:1019)

Thanks,

Eric

@michalgr
Copy link
Contributor

michalgr commented Dec 9, 2015

Thanks ! Can you reproduce this with Fresco 0.8.1 ? Can you share a link to a jpeg that you use to reproduce the issue ?

@michalgr michalgr added the needs-details This issue or PR is currently not actionable as it misses details (e.g. for reproducing the problem) label Dec 9, 2015
@eldk
Copy link
Contributor Author

eldk commented Dec 10, 2015

Hello,
It happened with fresco 0.8.1 library (without + at the end) on a reel Android API 10 device.

compile 'com.facebook.fresco:fresco:0.8.1'

Should I send you urls at michalgr at facebook dot com ?

Thanks,

Eric

@michalgr
Copy link
Contributor

michalgr at fb dot com

Thanks

@eldk
Copy link
Contributor Author

eldk commented Dec 11, 2015

Hello,

It's send.

Thanks,

Eric

@michalgr
Copy link
Contributor

I was able to display all the images using our uriapp without seeing any exceptions. How often does it reproduce ? Can you share the part of you code that creates and sets up the controller ?

@tyronen tyronen closed this as completed May 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-details This issue or PR is currently not actionable as it misses details (e.g. for reproducing the problem)
Projects
None yet
Development

No branches or pull requests

3 participants