-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build issue (Windows) #938
Comments
Which version are you trying to build? @massimocarli any ideas? Also we're trying to encourage moving these discussion to StackOverflow because we have a wider community that can help there. Ask on StackOverflow with the tag fresco and android. We're answering questions on stackoverflow but there are a lot more people in the community who can help you. |
Thanks. I grabbed the latest code from git. I have the last release of Android Studio running on Windows10 64Bit, NDK and SDK with all updates. It looks that is an NDK build problem around Bitmaps that I have no idea how to fix it. |
@syndycat What of you build from command line? |
@syndycat I met this situation too. defaultConfig {
ndk {
abiFilters "arm64-v8a"
}
} which define the ndk abi type. saved all of them and rebuild the whole fresco project. |
@syndycat any direction? |
I'm closing this issue due to inactivity. If this is still a problem, let us know! |
Summary: Thanks for submitting a PR! Please read these instructions carefully: - [x] Explain the **motivation** for making this change. - [x] Provide a **test plan** demonstrating that the code is solid. - [x] Match the **code formatting** of the rest of the codebase. - [x] Target the `master` branch What existing problem does the pull request solve? Fix build failed occurred by ndk settings ([Application.mk](https://developer.android.com/ndk/guides/application_mk)) Remove armeabi support (Remove from NDK r17) ``` > Task :imagepipeline:ndk_build_bitmaps FAILED A problem was found with the configuration of task ':imagepipeline:ndk_build_bitmaps'. Registering invalid inputs and outputs via TaskInputs and TaskOutputs methods has been deprecated and is scheduled to be removed in Gradle 5.0. - File '.../fresco/imagepipeline/src/main/jni/bitmaps' specified for property '$1' is not a file. Android NDK: APP_PLATFORM not set. Defaulting to minimum supported version android-14. Android NDK: WARNING: APP_STL gnustl_static is deprecated and will be removed in the next release. Please switch to either c++_static or c++_shared. See https://developer.android.com/ndk/guides/cpp-support.html for more information. Android NDK: The armeabi ABI is no longer supported. Use armeabi-v7a. .../Android/sdk/ndk-bundle/build/core/setup-app.mk:79: *** Android NDK: Aborting Android NDK: NDK Application 'local' targets unknown ABI(s): armeabi . Stop. Android NDK: Please fix the APP_ABI definition in ../Application.mk make: Entering directory `.../fresco/imagepipeline/src/main/jni/bitmaps' make: Leaving directory `.../fresco/imagepipeline/src/main/jni/bitmaps' ``` Relative issue: #24 #163 #286 #513 #591 #618 #938 #989 #1114 #1205 #1226 #1427 #1945 A good test plan has the exact commands you ran and their output, provides screenshots or videos if the pull request changes UI or updates the website. See [What is a Test Plan?][1] to learn more. If you have added code that should be tested, add tests. Build with NDK r17b <img width="677" alt="2018-06-15 11 00 00" src="https://user-images.githubusercontent.com/5742579/41448216-de9ac710-708b-11e8-865c-70ac85459d5c.png"> Sign the [CLA][2], if you haven't already. Small pull requests are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it. Make sure all **tests pass** on [Circle CI][4]. PRs that break tests are unlikely to be merged. For more info, see the [Contributing guide][4]. [1]: https://medium.com/martinkonicek/what-is-a-test-plan-8bfc840ec171#.y9lcuqqi9 [2]: https://code.facebook.com/cla [3]: http://circleci.com/gh/facebook/fresco [4]: https://github.com/facebook/fresco/blob/master/CONTRIBUTING.md Closes #2134 Reviewed By: erikandre Differential Revision: D8441064 Pulled By: oprisnik fbshipit-source-id: 6484f7714d738c9984c273a3e0513e31f730ff30
Hello,
I just grabed the latest code and, I followed the steps to build the lib.
I got the below JNI related error regarding the Bitmaps.
Did someone know how to fix it?
Thanks,
Cata
The text was updated successfully, but these errors were encountered: