fix #2497 #2501
fix #2497 #2501
Conversation
|
Hi @jokermonn! Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
？ |
There was a problem hiding this comment.
@oprisnik has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@jokermonn has updated the pull request. You must reimport the pull request before landing. |
|
@jokermonn has updated the pull request. You must reimport the pull request before landing. |
|
so, does it can not be merged? |
Motivation
fix #2497
The reason for the problem is that runnable's execution is asynchronous, and
com.facebook.datasource.AbstractDataSource#mDataSourceStatusmay change during this time.Because the first execution to this line will eventually result in the mDataSource being null, even though the two fields are the same on the second execution (line 5 of the log), the method returns false because the mDataSource is null, resulting in the onFailure method not being called(this method will return false).