Skip to content

Commit

Permalink
Use relative paths for intl dependencies
Browse files Browse the repository at this point in the history
Summary:
`HERMES_WS_DIR` should be reserved for build artefacts, and we can
use relative paths for referring to source code.

Reviewed By: Huxpro

Differential Revision: D28791952

fbshipit-source-id: 7d83acbffecc039a2b8441d5a1fe6521b31a7776
  • Loading branch information
neildhar authored and facebook-github-bot committed Jun 2, 2021
1 parent f61a798 commit 1986e4b
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion android/hermes/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ android {
intl {
java {
srcDirs = [
"${rootProject.ext.hermes_ws}/hermes/lib/Platform/Intl/java",
"../../lib/Platform/Intl/java",
]
}
}
Expand Down
6 changes: 3 additions & 3 deletions android/intltest/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ buildDir = "${rootProject.ext.hermes_ws}/build_android/intltest"
buildDir.mkdirs()

def test262DownloadsDirPath = "${rootProject.ext.hermes_ws}/build_android/intltest/downloads/test262"
def test262Destination = "${rootProject.ext.hermes_ws}/hermes/android/intltest/java/com/facebook/hermes/test/assets"
def test262Destination = "java/com/facebook/hermes/test/assets"
task createDownloadsDir {
new File(test262DownloadsDirPath).mkdirs()
}
Expand Down Expand Up @@ -112,8 +112,8 @@ android {
srcDirs = [
"java",
// Include AndroidUnicodeUtils, which would normally come from RN
"${rootProject.ext.hermes_ws}/hermes/lib/Platform/Unicode/java",
"${rootProject.ext.hermes_ws}/hermes/lib/Platform/Intl/java",
"../../lib/Platform/Unicode/java",
"../../lib/Platform/Intl/java",
]
}
resources {
Expand Down

0 comments on commit 1986e4b

Please sign in to comment.