Skip to content

Commit

Permalink
Revert quotes in build-apple-framework.sh
Browse files Browse the repository at this point in the history
Summary:
Linters (Shellcheck) suggested that args should be quoted but
that result in semantics changes breaking the build. It's easier
to leave the PR as is to unblock the release ASAP.

Reviewed By: mhorowitz

Differential Revision: D29631235

fbshipit-source-id: 8e5ca8551177e541bf82bab0b8b571df2a1b430c
  • Loading branch information
Huxpro authored and facebook-github-bot committed Jul 9, 2021
1 parent 62e5abe commit 520e010
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions utils/build-apple-framework.sh
Original file line number Diff line number Diff line change
Expand Up @@ -109,9 +109,9 @@ function create_universal_framework {
done

mkdir universal
xcodebuild -create-xcframework "$args" -output "universal/hermes.xcframework"
xcodebuild -create-xcframework $args -output "universal/hermes.xcframework"

for platform in "$@"; do
for platform in $@; do
rm -r "$platform"
done

Expand Down

0 comments on commit 520e010

Please sign in to comment.