Skip to content

Commit

Permalink
Increase default max stack size (#923)
Browse files Browse the repository at this point in the history
Summary:
As discussed in #135, the default stack size doesn't work for all use cases. In particular, when very large and complex bundles are loaded in dev mode.

This PR bumps the default stack size from `64*1024` (512kB) to `128*1024` (1MB). As suggested by tmikov in this comment - #135 (comment).

Pull Request resolved: #923

Reviewed By: tmikov

Differential Revision: D43630032

Pulled By: neildhar

fbshipit-source-id: 5f8cff91a5f01b6507870c61efa1ce507de67940
  • Loading branch information
mikeduminy authored and Riccardo Cipolleschi committed Mar 7, 2023
1 parent 21f15c5 commit ee25883
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion public/hermes/Public/RuntimeConfig.h
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ class PinnedHermesValue;
F(constexpr, PinnedHermesValue *, RegisterStack, nullptr) \
\
/* Register Stack Size */ \
F(constexpr, unsigned, MaxNumRegisters, 64 * 1024) \
F(constexpr, unsigned, MaxNumRegisters, 128 * 1024) \
\
/* Whether or not the JIT is enabled */ \
F(constexpr, bool, EnableJIT, false) \
Expand Down

0 comments on commit ee25883

Please sign in to comment.