Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Urgent warnings when running ninja against source #18

Closed
jacklaurencegaray opened this issue Jul 11, 2019 · 4 comments
Closed

Urgent warnings when running ninja against source #18

jacklaurencegaray opened this issue Jul 11, 2019 · 4 comments
Labels
bug Something isn't working need more info Awating additional info before proceeding

Comments

@jacklaurencegaray
Copy link

jacklaurencegaray commented Jul 11, 2019 •
edited
Loading 

Linking CXX executable bin/hermes
ld: warning: URGENT: building for OSX, but linking against dylib (/System/Library/Frameworks//CoreFoundation.framework/CoreFoundation) built for (unknown). Note: This will be an error in the future.
ld: warning: URGENT: building for OSX, but linking against dylib (/usr/lib/libicucore.dylib) built for (unknown). Note: This will be an error in the future.
ld: warning: URGENT: building for OSX, but linking against dylib (/usr/lib/libcurses.dylib) built for (unknown). Note: This will be an error in the future.
ld: warning: URGENT: building for OSX, but linking against dylib (/usr/lib/libm.dylib) built for (unknown). Note: This will be an error in the future.
ld: warning: URGENT: building for OSX, but linking against dylib (/usr/lib/libc++.dylib) built for (unknown). Note: This will be an error in the future.
ld: warning: URGENT: building for OSX, but linking against dylib (/usr/lib/libSystem.dylib) built for (unknown). Note: This will be an error in the future.
ld: warning: URGENT: building for OSX, but linking against dylib (/usr/lib/libz.dylib) built for (unknown). Note: This will be an error in the future.

Running ninja seems to trigger the above warnings. Not sure if this matters.

OS version: macOS Mojave 10.14.6
Ninja version: 1.9.0
@jacklaurencegaray jacklaurencegaray changed the title URGENT: building for OSX, but linking against dylib (/System/Library/Frameworks//CoreFoundation.framework/CoreFoundation) built for (unknown). Note: This will be an error in the future. Urgent warnings when running ninja from source Jul 11, 2019
@jacklaurencegaray jacklaurencegaray changed the title Urgent warnings when running ninja from source Urgent warnings when running ninja against source Jul 11, 2019
@dulinriley
Copy link
Contributor

I'm on the same OS and ninja versions, and I haven't encountered this error.
This might actually be a difference in C++ compilers/linkers.
Can you run

~ $ c++ --version
Apple LLVM version 10.0.1 (clang-1001.0.46.4)
Target: x86_64-apple-darwin18.6.0
Thread model: posix
InstalledDir: /Applications/Xcode_10.2.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

If you're either using an older clang, or a newer clang, it might be due to that.
In general, we recommend using the latest stable Xcode C++ compiler for MacOS builds (which is 10.2.1 right now).

@dulinriley dulinriley added the bug Something isn't working label Jul 15, 2019
@willholen
Copy link
Contributor

@jacklaurencegaray What's the output of ld -v and c++ --version?

@willholen willholen added the need more info Awating additional info before proceeding label Jul 19, 2019
@jacklaurencegaray
Copy link
Author

jacklaurencegaray commented Jul 20, 2019 •
edited
Loading

@willholen

ld -v

@(#)PROGRAM:ld PROJECT:ld64-351.8
configured to support archs: armv6 armv7 armv7s arm64 i386 x86_64 x86_64h armv6m armv7k armv7m armv7em (tvOS)
LTO support using: LLVM version 9.1.0, (clang-902.0.39.2) (static support for 21, runtime is 21)
TAPI support using: Apple TAPI version 9.1.0 (tapi-902.0.9)

c++ --version

Apple LLVM version 9.1.0 (clang-902.0.39.2)
Target: x86_64-apple-darwin18.7.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

@willholen
Copy link
Contributor

From what I can gather from web searches, this is more related to the currently installed libraries than to the build process itself. I was not able to reproduce it on Mojave 10.14.6 with Apple LLVM version 10.0.1 (clang-1001.0.46.4), and I think it shouldn't matter.

I'll be sure to keep an eye on it, though. Thanks for reporting!

facebook-github-bot pushed a commit that referenced this issue Oct 28, 2019
@dreiss @facebook-github-bot
Support get[Static]Field without ::javaobject (#18)
e93b3cb 
Summary:
Treat `getField<JFoo>` as equivalent to `getField<JniType<JFoo>>`,
which is equivalent to `getField<JFoo::javaobject>`.

This required introducing a new metaprogramming struct,
`PrimitiveOrJniType`, which works like `JniType`, but passes through
Java primitives.

Pull Request resolved: facebookincubator/fbjni#18

Test Plan: CI

Reviewed By: cjhopman

Differential Revision: D18121231

Pulled By: dreiss

fbshipit-source-id: 6c1db54263e40a9f438172cc134394e57cf3f752
@whatleo whatleo mentioned this issue Apr 1, 2021
Closed
@vietmobilefolk vietmobilefolk mentioned this issue Sep 22, 2022
Closed
@DevFuan DevFuan mentioned this issue Jan 12, 2023
Open
@iwater iwater mentioned this issue May 25, 2023
Closed
1 task
@JimWongM JimWongM mentioned this issue Jun 17, 2023
Open
@atoui-zahreddine atoui-zahreddine mentioned this issue Feb 9, 2024
Closed
2 tasks
@jtdaugh jtdaugh mentioned this issue Jul 9, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working need more info Awating additional info before proceeding
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dulinriley @jacklaurencegaray @willholen