-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hermes is slower then JSC when using cached JSRuntime #50
Comments
We would love to help. Is there a way you could create a test project that is similar to your app ? That will help us recreate and investigate this scenario better. |
@axemclion Thanks very much This is my demo project: https://github.com/chufengma/HermesTestDemo Time-consuming comparison between JSC and Hermesrun demoRun with Hermes
|
@chufengma - looks like there are some compile errors in the project - something around |
@axe-fb |
I don't know gradle very well. Is installDebug giving you the debug Hermes build, or the release build? The latter will perform better. |
@mhorowitz installRelease has the same problem. |
@axe-fb any updates? |
Hey, I am still having trouble running the demo project - this time the error is around Can I request you to remove all un-needed dependencies, and have a smaller repro, so that it is easier for me to run this project ? Also, could you add a |
@chufengma - any update ? Wanted to take a look at this over the weekend. |
@axe-fb updated https://github.com/chufengma/HermesTestDemo today and remove some un-needed dependencies(I'm sorry it took so long to update -。-). |
@chufengma , I ran the tests 20 times, with updated ReactMarker listeners. I did not find that Hermes is slower. Here are the results. Could you also get similar data, with the markers (sent you a PR) to see if you have a similar issue ?
|
@axemclion My problem is that when loading RN pages for the second time, Hermes is slower than JSC. When I start my app, click the Load RN undle button, and through the ReactMaker I can see the data listed above. These data show that Hermes is faster than JSC without caching. But when I press the return key to exit the RN page and click the Load RN bundle button again, this time using caching, Hermes is much slower than jsc, and at this time only the following logs can be seen through ReactMaker:
|
After upgrading to 0.2.1, the problem is solved. |
Update triggers to use the new main branch name
My React Native project is different from the official React Native project:I cached ReactInstanceManager when user leave the last ReactNative Activity. When the user enters the same page again, the cached ReactInstanceManager is used.
When I use jsc, it takes 200 ms for me to enter the same page the second time, but more than 500 ms for hermes.
I'm very interested in hermes, but this problem is blocking me now. Can you give me some help or ideas?
The text was updated successfully, but these errors were encountered: