-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generators support #52
Comments
This is a version skew issue. Generators are supported in master and in the initial github commit, but due to some manual steps to make the initial binary release before OSS launch, didn't make it into the v0.1.0 build. If you build from master, then generator.js should work. When we make the next binary release, for-of and generators should be equally supported. We're working on better release automation so it's less error-prone in the future. Sorry for the confusion! |
Summary: Pull Request resolved: facebookincubator/fbjni#52 Reviewed By: mweststrate Differential Revision: D26815823 Pulled By: passy fbshipit-source-id: 90c5806d087663025dc504cdb0bc90f60161220d
The documentation claims that generators are supported in Hermes, as well as for-of loops:
hermes/doc/Features.md
Lines 5 to 12 in 9cf7a40
Consider this gist: https://gist.github.com/noomorph/f9272f1a3f4a9d1f419c2e8dadfb5fe2
As for for-of.js, the command below runs successfully, thereby confirming built-in support for that construct:
> ./hermes for-of.js 0 1 2
As for generator.js, a similar command would fail, like shown below:
Steps to reproduce
cd
into it.Expected result
I see a few options - either:
Actual result
While
for-of
andgenerators
stand in the very sameSupported features
list side by side, I see major differences in how they are supported in Hermes. More clarity won't hurt if we bring it in.The text was updated successfully, but these errors were encountered: