Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Array.prototype.at #823

Closed
magom001 opened this issue Sep 30, 2022 · 2 comments
Closed

Add Array.prototype.at #823

magom001 opened this issue Sep 30, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@magom001
Copy link

Problem

Array.prototype.at is stable and is supported by all major browsers (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/at). Please consider adding it to hermes.

Solution

I can produce a PR for this.
@magom001 magom001 added the enhancement New feature or request label Sep 30, 2022
@ljharb
Copy link

ljharb commented Sep 30, 2022

Also String.prototype.at and %TypedArray%.prototype.at, which were all part of the same proposal and should be added at the same time.

facebook-github-bot pushed a commit that referenced this issue Oct 24, 2022
@facebook-github-bot
Support at methods for Array, TypedArray, and String
ebe2915 
Summary: Solve the gap raised in #823. Add support for `.prototype.add` for Array, TypedArray, and String. The implementation closely follows the spec.

Reviewed By: jpporto

Differential Revision: D40497162

fbshipit-source-id: 0b317fda2d66ac566c10dee19626c728c4c8cc41
@fbmal7 fbmal7 closed this as completed Nov 1, 2022
@fbmal7
Copy link
Contributor

fbmal7 commented Nov 1, 2022

@magom001 implemented in ebe2915

facebook-github-bot pushed a commit that referenced this issue Nov 18, 2022
@avp @facebook-github-bot
Support at methods for Array, TypedArray, and String
956211b 
Summary:
Solve the gap raised in #823. Add support for `.prototype.add` for Array, TypedArray, and String. The implementation closely follows the spec.

Original Author: fbmal7
Original Git: 8d3933c1a0f758ee3ee3db4c9e02c4106d5bf70b

Original Reviewed By: jpporto

Original Revision: D40497162

Reviewed By: tmikov

Differential Revision: D41240776

fbshipit-source-id: 99ec74d26d2e81b8f47ee1ad51fb8f95e2f26326
avp added a commit to avp/hermes that referenced this issue Nov 22, 2022
@avp
Support at methods for Array, TypedArray, and String
a1b340b 
Summary:
Solve the gap raised in facebook#823. Add support for `.prototype.add` for Array, TypedArray, and String. The implementation closely follows the spec.

Original Author: fbmal7
Original Git: ebe2915

Original Reviewed By: jpporto

Original Revision: D40497162

Reviewed By: tmikov

Differential Revision: D41240776

fbshipit-source-id: 99ec74d26d2e81b8f47ee1ad51fb8f95e2f26326
neildhar pushed a commit to neildhar/hermes that referenced this issue Nov 22, 2022
@avp @neildhar
Support at methods for Array, TypedArray, and String
e517e56 
Summary:
Solve the gap raised in facebook#823. Add support for `.prototype.add` for Array, TypedArray, and String. The implementation closely follows the spec.

Original Author: fbmal7
Original Git: 8d3933c1a0f758ee3ee3db4c9e02c4106d5bf70b

Original Reviewed By: jpporto

Original Revision: D40497162

Reviewed By: tmikov

Differential Revision: D41240776

fbshipit-source-id: 99ec74d26d2e81b8f47ee1ad51fb8f95e2f26326
neildhar pushed a commit to neildhar/hermes that referenced this issue Nov 23, 2022
@avp @neildhar
Support at methods for Array, TypedArray, and String
4bfaa8b 
Summary:
Solve the gap raised in facebook#823. Add support for `.prototype.add` for Array, TypedArray, and String. The implementation closely follows the spec.

Original Author: fbmal7
Original Git: ebe2915

Original Reviewed By: jpporto

Original Revision: D40497162

Reviewed By: tmikov

Differential Revision: D41240776

fbshipit-source-id: 99ec74d26d2e81b8f47ee1ad51fb8f95e2f26326
neildhar pushed a commit to neildhar/hermes that referenced this issue Nov 23, 2022
@avp @neildhar
Support at methods for Array, TypedArray, and String
4ef3957 
Summary:
Solve the gap raised in facebook#823. Add support for `.prototype.add` for Array, TypedArray, and String. The implementation closely follows the spec.

Original Author: fbmal7
Original Git: 8d3933c1a0f758ee3ee3db4c9e02c4106d5bf70b

Original Reviewed By: jpporto

Original Revision: D40497162

Reviewed By: tmikov

Differential Revision: D41240776

fbshipit-source-id: 99ec74d26d2e81b8f47ee1ad51fb8f95e2f26326
neildhar pushed a commit to neildhar/hermes that referenced this issue Nov 23, 2022
@avp @neildhar
Support at methods for Array, TypedArray, and String
4c7676c 
Summary:
Solve the gap raised in facebook#823. Add support for `.prototype.add` for Array, TypedArray, and String. The implementation closely follows the spec.

Original Author: fbmal7
Original Git: ebe2915

Original Reviewed By: jpporto

Original Revision: D40497162

Reviewed By: tmikov

Differential Revision: D41240776

fbshipit-source-id: 99ec74d26d2e81b8f47ee1ad51fb8f95e2f26326
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ljharb @magom001 @fbmal7