Draft: Implement formatRange and formatRangeToParts on Apple and Android platforms #1219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many tests which use "const" are not actually testing the behavior of the "const" keyword, they are just using it as it is standard practice in newer JavaScript versions. This allows allowlisting individual tests or directories which use "const". This commit additionally updates the skiplist for ECMA-402 2024
Also update the Android test262 runner to print the individual testcases for debugging and visibility.
In DateTimeFormat the switch statement for the fractionalSecondDigits skeleton currently is missing "break" statements - leading to incorrect skeleton strings (e.g. SSSSSSS)
facebook-github-bot
added
the
CLA Signed
|
I'm working on breaking apart our internal work into distinct MRs, this is currently rebased on #1218 but I may drop those commits soon. |
ewlsh
force-pushed
the
evanmh-intl-datetimeformat-format-range
branch
2 times, most recently
from
b2168d8
to
a692325
Compare
- Add support for canonicalizing timezone names - Add support for "backward" link timezone names - Support timezone offset strings - Expose "locale data" by mapping keys to NS APIs
ewlsh
force-pushed
the
evanmh-intl-datetimeformat-format-range
branch
from
a692325
to
1ccd29a
Compare
ewlsh
commented
Dec 12, 2023
| @@ -0,0 +1,11 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We want to support
formatRangeandformatRangeToPartsforIntl.DateTimeFormaton Android and iOS. Our company uses the Android implementation internally and will use the iOS implementation once we move iOS to Hermes.I've added a basic fallback for older Android versions, we don't use this internally but I'll test it.
For Apple this introduces support for
formatToPartsusing the skeleton string to "build" each part - formatting the parts individually. This is expensive but can be avoided in the future if we move the implementation to Swift and utilize Swift'sAttributedString. Apple has been working on Swift/C++ cmake interop.For Android and Apple this introduces support for
formatRangeuses the respective interval formatters on both platforms.Test Plan
Adding support for existing test262 tests and porting some tests to the internal testsuite where the data won't align to do limitations in the Apple implementation